feat: add an L2 token retriever contract which calls exported spoke pool functions #605
+443
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ract Signed-off-by: bennett <[email protected]>
Signed-off-by: bennett <[email protected]>
Signed-off-by: bennett <[email protected]>
bmzig
commented
Sep 16, 2024
Signed-off-by: bennett <[email protected]>
pxrl
reviewed
Sep 17, 2024
bmzig
changed the title
Signed-off-by: bennett <[email protected]>
Signed-off-by: bennett <[email protected]>
Signed-off-by: bennett <[email protected]>
Signed-off-by: bennett <[email protected]>
mrice32
reviewed
Sep 19, 2024
| } else { | ||
| // Check that the Ethereum counterpart of the L2 token is stored on this contract. | ||
| // Tokens will only be bridged if they are whitelisted by the spoke pool. | ||
| address ethereumTokenToBridge = spokePool.whitelistedTokens(l2TokenAddress); |
There was a problem hiding this comment.
I don't love the dependency on the spoke pool, especially since we may end up wanting the spoke pool to call into this contract.
But I can't really think of a way to get this list elsewhere without adding a lot of complexity or additional args that wouldn't apply on non-arbitrum chains... maybe we could add a bytes arg that can be used to supply extra context when needed, but that makes the interface sort of convoluted.
Any ideas?
Signed-off-by: bennett <[email protected]>
bmzig
changed the base branch from
bz/ArbitrumForwarders
to
bz/l2ForwarderInterface
Signed-off-by: bennett <[email protected]>
Signed-off-by: bennett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There will be shared logic between L2 token retrievers which need to bridge funds from L3 back to L1 and L2 spoke pool logic. We may be able to factor this out for each chain and create another adapter-like contract which can be
delegatecall-ed by both L2 token retriever and spoke pool contracts.