-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generic L2 forwarder base contract #609
Conversation
Signed-off-by: bennett <[email protected]>
contracts/chain-adapters/interfaces/ArbitrumForwarderInterface.sol
Outdated
Show resolved
Hide resolved
contracts/chain-adapters/interfaces/ArbitrumForwarderInterface.sol
Outdated
Show resolved
Hide resolved
contracts/chain-adapters/interfaces/ArbitrumForwarderInterface.sol
Outdated
Show resolved
Hide resolved
Signed-off-by: bennett <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! A few comments
contracts/chain-adapters/interfaces/ArbitrumForwarderInterface.sol
Outdated
Show resolved
Hide resolved
contracts/chain-adapters/interfaces/ArbitrumForwarderInterface.sol
Outdated
Show resolved
Hide resolved
contracts/chain-adapters/interfaces/ArbitrumForwarderInterface.sol
Outdated
Show resolved
Hide resolved
contracts/chain-adapters/interfaces/ArbitrumForwarderInterface.sol
Outdated
Show resolved
Hide resolved
Signed-off-by: bennett <[email protected]>
Signed-off-by: bennett <[email protected]>
Signed-off-by: bennett <[email protected]>
Signed-off-by: bennett <[email protected]>
Signed-off-by: bennett <[email protected]>
Signed-off-by: bennett <[email protected]>
Signed-off-by: bennett <[email protected]>
Signed-off-by: bennett <[email protected]>
Signed-off-by: bennett <[email protected]>
Signed-off-by: bennett <[email protected]>
Signed-off-by: bennett <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments on naming. You shouldn't take naming lightly, it's the difference between code that is easy to review and code that's not, and that's a major difference in code quality.
Signed-off-by: bennett <[email protected]>
Signed-off-by: bennett <[email protected]>
Co-authored-by: Matt Rice <[email protected]>
Signed-off-by: bennett <[email protected]>
Signed-off-by: bennett <[email protected]>
@bmzig This description probably needs an update to reflect the changes that were made during review. |
Signed-off-by: bennett <[email protected]>
Signed-off-by: bennett <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK from me!
This PR adds the abstract contract
ForwarderBase
which is meant to be a base for forwarders. Forwarders should relay messages/tokens from an L2 to an L3. A forwarder which inheritsForwarderBase
will have to be constructed for each chain to account for an L2's message validation logic, but sinceForwarderBase
makes use of L2 adapters, it shouldn't matter what the architecture of the L3 is. To be clear, only_requireAdminSender
, an internal function which ensures that the caller is the aliased hub pool, must be implemented for each new forwarder.