Add missing events and re-factor event location #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrismaree <[email protected]>
Signed-off-by: chrismaree <[email protected]>
Reinis-FRP
reviewed
Sep 23, 2024
programs/svm-spoke/src/event.rs
Outdated
| pub input_amount: u64, | ||
| pub output_amount: u64, | ||
| pub destination_chain_id: u64, | ||
| pub deposit_id: u64, |
There was a problem hiding this comment.
depositId is uint32 in EVM SpokePool, and we also use u32 in fills
Signed-off-by: chrismaree <[email protected]>
Reinis-FRP
reviewed
Sep 23, 2024
Signed-off-by: chrismaree <[email protected]>
Reinis-FRP
reviewed
Sep 23, 2024
| @@ -7,7 +7,7 @@ pub struct State { | |||
| pub paused_fills: bool, | |||
| pub owner: Pubkey, | |||
| pub seed: u64, // Add a seed to the state to enable multiple deployments. | |||
| pub number_of_deposits: u64, | |||
| pub number_of_deposits: u32, | |||
There was a problem hiding this comment.
also need u32 in initial_number_of_deposits in initialize both in lib and admin.
Signed-off-by: chrismaree <[email protected]>
Reinis-FRP
approved these changes
Sep 23, 2024
Signed-off-by: chrismaree <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR add an additional events and pulls events into a common defined location.