feat: mint + burn routing logic #1864
Conversation
ashwinrava
requested review from
mrice32,
nicholaspai,
dohaki,
james-a-morris,
pxrl,
melisaguevara and
amateima
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ashwinrava
changed the base branch from
master
to
mguevara/acx-4479-add-cctp-bridge-strategy
| const isLargeDeposit = depositAmountUsd > 1_000_000; // 1M USD | ||
|
|
||
| // Check if eligible for Fast CCTP (Polygon, BSC, Solana) and deposit > 10K USD | ||
| const fastCctpChains = [CHAIN_IDs.POLYGON, CHAIN_IDs.BSC, CHAIN_IDs.SOLANA]; |
There was a problem hiding this comment.
Should this be part of the CCTP bridge strategy?
There was a problem hiding this comment.
Yes, for this use case we are already exporting CCTP_FILL_TIME_ESTIMATES from the strategy. Maybe we can use that combined with a threshold.
There was a problem hiding this comment.
fast CCTP chains can be taken from here. Chains with "seconds" are considered fast
ashwinrava
force-pushed
the
ashwin/acx-4481-implement-acrossnative-routing-logic
branch
from
a8c41f2 to
671465d
Compare
ashwinrava
changed the base branch from
mguevara/acx-4479-add-cctp-bridge-strategy
to
master
ashwinrava
changed the base branch from
master
to
feat/mint-burn-bridge-routing
| if (bridgeStrategyData.isUtilizationHigh) { | ||
| return getCctpBridgeStrategy(); | ||
| } |
There was a problem hiding this comment.
when utilization is high CCTP strategy should be used only for USDC, right?
|
|
||
| import { CrossSwap, CrossSwapQuotes, Token } from "../_dexes/types"; | ||
| import { AppFee, CrossSwapType } from "../_dexes/utils"; | ||
| import { Logger } from "@across-protocol/sdk/dist/types/relayFeeCalculator"; |
There was a problem hiding this comment.
I see we have some utils in api/_logger.ts. Can we use getLogger from there?
| return getAcrossBridgeStrategy(); | ||
| } else { | ||
| // Use OFT bridge if not CCTP | ||
| return getCctpBridgeStrategy(); |
There was a problem hiding this comment.
for all these checks, should we check if the strategy we want to return is part of the supportedBridgeStrategies list? That way we avoid returning here a strategy that was previously filtered out.
| const isFastCctpChain = | ||
| fastCctpChains.includes(inputToken.chainId) || | ||
| fastCctpChains.includes(outputToken.chainId); |
There was a problem hiding this comment.
I think only the origin chain matters here.
| const utilizationThreshold = sdk.utils.fixedPointAdjustment.mul(80).div(100); // 80% | ||
|
|
||
| // Calculate current utilization percentage | ||
| const currentUtilization = _utilizedReserves |
There was a problem hiding this comment.
I think utilizedReserves can be negative, would that have any impact in this calculation?
I see in other places we floored it to zero when that happens. See for example: https://github.com/across-protocol/frontend/blob/master/api/_utils.ts#L2709
| }); | ||
|
|
||
| // Safely return undefined if we can't fetch bridge strategy data | ||
| return undefined; |
There was a problem hiding this comment.
We could instead return the expected JSON object but all fields set to false?
This would be a more clear return type than undefined.
| const depositAmountUsd = parseFloat( | ||
| ethers.utils.formatUnits(amountInInputTokenDecimals, inputToken.decimals) | ||
| ); | ||
| const isInThreshold = depositAmountUsd <= 10_000; // 10K USD |
There was a problem hiding this comment.
Maybe we want to consider extracted hardcoded variables into a single place. This would help us later to make changes or understand why certain thresholds were set.
| return getAcrossBridgeStrategy(); | ||
| } else { | ||
| // Use OFT bridge if not CCTP | ||
| return getCctpBridgeStrategy(); |
There was a problem hiding this comment.
The comment here says that we should use OFT bridge if not CCTP but the return function indicates that we are using the cctp bridge strategy.
This PR implements the routing logic below. Changes here: a8c41f2
/limitsto return utilization data so that we don't need to refetch itlimitswith a standard amount to maximize cache hits