Skip to content

Revert "fix: incorrect token information in response for wetheth" #1880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2025
Merged

Revert "fix: incorrect token information in response for wetheth" #1880

merged 1 commit into from
Oct 7, 2025
+6 −64

Conversation

NikolasHaimerl
Copy link
Contributor

Reverts #1867

@linear Linear
Copy link

linear bot commented Oct 7, 2025

Issue reopened: ACX-4369 Incorrect token information in response for WETH/ETH

@vercel Vercel
Copy link

vercel bot commented Oct 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
app-frontend-v3 Ready Ready Preview Comment Oct 7, 2025 10:25am
sepolia-frontend-v3 Ready Ready Preview Comment Oct 7, 2025 10:25am

@NikolasHaimerl NikolasHaimerl marked this pull request as ready for review October 7, 2025 10:14
amateima
amateima reviewed Oct 7, 2025
View reviewed changes
Copy link
Contributor

@amateima amateima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the revert reason?

@NikolasHaimerl
Copy link
Contributor Author

What's the revert reason?

Master is currently failing on the CI due to some discrepancy between preview and production deployments to Vercel.
I could not figure out the reason for this difference in the deployed versions of the API.
Until I do I want to revert the change so the master CI is succeeding again.

@NikolasHaimerl NikolasHaimerl merged commit cd8fcfb into master Oct 7, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amateima amateima amateima left review comments

@dohaki dohaki dohaki approved these changes

@mrice32 mrice32 Awaiting requested review from mrice32 mrice32 is a code owner

@nicholaspai nicholaspai Awaiting requested review from nicholaspai nicholaspai is a code owner

@pxrl pxrl Awaiting requested review from pxrl pxrl is a code owner

@melisaguevara melisaguevara Awaiting requested review from melisaguevara melisaguevara is a code owner

@ashwinrava ashwinrava Awaiting requested review from ashwinrava ashwinrava is a code owner

@gsteenkamp89 gsteenkamp89 Awaiting requested review from gsteenkamp89 gsteenkamp89 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NikolasHaimerl @dohaki @amateima