improve: Create SVM relayDataHash with messageHash instead of message #1168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxrl
reviewed
Aug 4, 2025
There was a problem hiding this comment.
@dijanin-brat Just one general comment here - we already have messageHash on both FundsDeposited and FilledRelay events - does it make sense to just update the type of RelayData on each of these function prototypes to include messageHash ?
i.e.:
relayData: RelayData: & { messageHash: string },
pxrl
reviewed
Aug 6, 2025
src/arch/svm/SpokeUtils.ts
Outdated
| * @param provider - SVM provider instance. | ||
| * @param svmEventsClient - SVM events client for querying events. | ||
| * @param atHeight - (Optional) Specific slot number to query. Defaults to the latest confirmed slot. | ||
| * @param messageHash - (Optional) Hash of the message that will be used to create relayDataHash from fill. |
There was a problem hiding this comment.
Should be OK to drop this one now 👍
Suggested change
| * @param messageHash - (Optional) Hash of the message that will be used to create relayDataHash from fill. |
pxrl
approved these changes
Aug 6, 2025
src/arch/svm/utils.ts
Outdated
| * @param programId The SpokePool program ID. | ||
| * @param relayData The relay data to get the fill status PDA for. | ||
| * @param destinationChainId The destination chain ID. | ||
| * @param messageHash Hash of the message that will be used to create relayDataHash from fill. |
There was a problem hiding this comment.
Same as above.
Suggested change
| * @param messageHash Hash of the message that will be used to create relayDataHash from fill. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create SVM relayDataHash with messageHash instead of message.