Skip to content

Conversation

grasphoper
Copy link
Contributor

@grasphoper grasphoper commented Sep 18, 2025

To account for native token cost, like value_amount in SVM Spoke

We don't rely on TX simulation, but rather rely on contract enforcing the fixed relayer native token spend when passing in the value_amount as a part of AcrossPlusMessage

Signed-off-by: Ihor Farion <[email protected]>
Signed-off-by: Ihor Farion <[email protected]>
@grasphoper
Copy link
Contributor Author

@dohaki noticed that updates to relayerFeeDetails are missing. Looking into that now

Signed-off-by: Ihor Farion <[email protected]>
Signed-off-by: Ihor Farion <[email protected]>
Signed-off-by: Ihor Farion <[email protected]>
Signed-off-by: Ihor Farion <[email protected]>
@grasphoper
Copy link
Contributor Author

grasphoper commented Sep 19, 2025

@fusmanii @bmzig please take a look, I added some changes since you guys last reviewed. In particular, RelayFeeCalculator.relayerFeeDetails changed to reflect the new aux native fee changes.

Notice also that this introduced a breaking change to the RelayFeeCalculator.gasFeePercent, which is why the tests broke. I checked relayer and frontend codebases though and they weren't using this function directly so no changes are needed there with regards to this breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants