Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add name to session model #100

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add name to session model #100

wants to merge 3 commits into from

Conversation

gthomas-slack
Copy link
Contributor

  • Adds the session name to the session model
  • Updates the from_json session model to use the name if it is provided in the livy API response
  • Updates failing mypy test to include missing types (this failure seems to be unrelated to the changes above)

@gthomas-slack
Copy link
Contributor Author

Hi @acroz wondering if you would have a chance to look at this? thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traviscook21 traviscook21 traviscook21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gthomas-slack @traviscook21