feat: Add some accessibility updates to BarChart component #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…description props
joncursi
approved these changes
Jul 24, 2024
ptakizawa-daitan
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recharts has recently published an update that allows keyboard accessibility for certain charts. This PR adds that prop to the BarChart component and also exposes an optional title and description prop that screen readers can access.
Even though the
accessibilityLayerprop has been added to the chart it's unfortunately not yet fully keyboard accessible. After this PR is merged I will create an issue with recharts to see why it's not working as described in their documentation. They have quite a few open accessibility issues so I'm hopeful that this could be fixed in future recharts versions.