Skip to content

Text is clipped: "link to a full version" #2200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Text is clipped: "link to a full version" #2200

wants to merge 5 commits into from

Conversation

dan-tripp-siteimprove
Copy link
Collaborator

Closes issue(s):

Need for Call for Review:
This will require a 1 week Call for Review

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@dan-tripp-siteimprove dan-tripp-siteimprove self-assigned this Jun 28, 2024
@dan-tripp-siteimprove dan-tripp-siteimprove added the Editorial For editorial changes that does not change the meaning of a rule or Glossary term label Jun 28, 2024
WilcoFiers
WilcoFiers requested changes Jul 25, 2024
View reviewed changes
Copy link
Member

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion

Jym77
Jym77 reviewed Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@Jym77 Jym77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Not formally approving to get the "3 organisations" in.

@Jym77
Copy link
Collaborator

Jym77 commented Feb 20, 2025

Call for review ends on February 27th.

@Jym77 Jym77 added Review Call 1 week Call for review for small changes and removed reviewers wanted labels Feb 20, 2025
@netlify Netlify
Copy link

netlify bot commented Mar 17, 2025 •
edited
Loading

✅ Deploy Preview for act-rules ready!

Name Link
🔨 Latest commit d7bc678
🔍 Latest deploy log https://app.netlify.com/sites/act-rules/deploys/67d82f825e6c250008181dda
😎 Deploy Preview https://deploy-preview-2200--act-rules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jym77 Jym77 Jym77 left review comments

@WilcoFiers WilcoFiers WilcoFiers approved these changes

@carlosapaduarte carlosapaduarte carlosapaduarte approved these changes

@colabottles colabottles colabottles approved these changes

@daniel-montalvo daniel-montalvo daniel-montalvo approved these changes

@giacomo-petri giacomo-petri giacomo-petri approved these changes

@kengdoj kengdoj Awaiting requested review from kengdoj

Assignees

@dan-tripp-siteimprove dan-tripp-siteimprove

Labels
Editorial For editorial changes that does not change the meaning of a rule or Glossary term Review Call 1 week Call for review for small changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Zoomed text node is not clipped with CSS overflow": "link to a full version": source unclear
7 participants
@dan-tripp-siteimprove @Jym77 @WilcoFiers @carlosapaduarte @colabottles @daniel-montalvo @giacomo-petri