document auth property in webhooks section of processing chain #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmacata
reviewed
Jan 31, 2023
mmacata
approved these changes
Jan 31, 2023
There was a problem hiding this comment.
Cool, thanks!
This should be the corret place, yes. To test it is possible to start actinia locally and then call /api/v3/swagger.json to receive the json. This URL can be entered into https://petstore.swagger.io/ - for me it doesn't work in any browser as a local URL is adressed but it used to work in Firefox.
Co-authored-by: Carmen Tawalika <[email protected]>
mmacata
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to document the
authproperty in thewebhookssection of a processing chain. Currently, this is not visible in swagger.json / ReDoc.I have not tested it and I am not sure this is the right way to add to the documentaion...
It would be good it
authwould support base64 encoded strings (instead of username and password in plain text), or even better, if actinia had secrets management (like e.g. in github actions, see also: #398).