Demoded controls #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actioninja
force-pushed
the
demoded-controls
branch
from
a2d918f
to
97f24e4
Compare
I believe both shorts and mediums can encode a one more offset byte. 0b1111_1111 + 1 = 1024 0b11_1111_1111_1111 + 1 = 16384
actioninja
force-pushed
the
demoded-controls
branch
from
e791c22
to
40fac4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Huge refactor to remove the complicated code surrounding multiple control modes, since apparently Simcity 4 doesn't have a nonstandard control code format.
Debating whether to entirely remove the "Format" trait in favor of just passing the header mode,
closes #4
closes #5