Timeout fix #170
Merged
Timeout fix #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesMGreene
suggested changes
May 12, 2023
There was a problem hiding this comment.
Overall, I like the changes and the intention of the newly added tests. 👍🏻
For an approval, I'd like to see all of the comments marked as "🛑 Blocker" or "🧹 Cleanup" taken care of. The other comments (e.g. " 💡 Idea") are food for thought but can ultimately be ignored.
Co-authored-by: James M. Greene <[email protected]>
This reverts commit 3e2c26d.
JamesMGreene
approved these changes
May 12, 2023
JamesMGreene
suggested changes
May 12, 2023
JamesMGreene
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #165
Closes #166