Expose job name as env var #3281
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Link- @nikola-jokic @TingluoHuang could this change be considered as an addition to the runner? |
|
Gentle ping on this one @Link- @nikola-jokic @TingluoHuang . Is there anything I can do to get this reviewed? |
|
This is a duplicate of #3489, and no one is reviewing this and @TingluoHuang closed this without merging before but hasn't replied why. |
|
The simple fact of the matter is jobname+ matrix inputs exceeding 97 characters gets truncated... Which leads to job names that are unique on start but are not unique on the API search... Tldr: truncating the uuid of a job is not good. Not giving you a uuid to search for is worse. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the job display name as an environment variable. The job display name is exposed in webhooks as
name(docs) so having it as an environment variable allows correlating data between the webhooks and processes that run in the runner.This change would be specifically useful to improve Datadog's CI Visibility integration with GitHub Actions, where we currently require users to manually expose the job name as a variable for the integration to fully work (docs).
If this change is acceptable for the runner team, I am also happy to open a PR to update the documentation around default environment variables (docs).