Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1567:新增版本比较工具函数 #2439

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Issue1567:新增版本比较工具函数 #2439

merged 4 commits into from
Jun 13, 2024

Conversation

winfredLIN
Copy link
Collaborator

@winfredLIN winfredLIN commented May 30, 2024

关联的 issue

https://github.com/actiontech/sqle-ee/issues/1567

描述你的变更

  1. 引入版本解析包
    https://pkg.go.dev/github.com/hashicorp/go-version#section-readme
    https://github.com/hashicorp/go-version
    STAR 1.6k
    被引用数量:Imported by 4,943
  2. 新增工具函数,比较版本号
  3. 为该函数新增单元测试

确认项(pr提交后操作)

Tip

请在指定复审人之前,确认并完成以下事项,完成后✅


  • 我已完成自测
  • 我已在关联的issue里补充了实现方案
  • 我已在关联的issue里补充了测试影响面
  • 我已确认了变更的兼容性,如果不兼容则在issue里标记 not_compatible
  • 我已确认了是否要更新文档,如果要更新则在issue里标记 need_update_doc

@winfredLIN winfredLIN requested review from ColdWaterLW and sjjian and removed request for ColdWaterLW May 30, 2024 08:08
@sjjian sjjian merged commit 4c43029 into main Jun 13, 2024
3 checks passed
@sjjian sjjian deleted the issue1567 branch June 13, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants