Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update responders config to match default error_status & redirect_status codes for current rails version #863

Closed
wants to merge 2 commits into from

Conversation

a-nickol
Copy link

Update responder class to the current defaults for responder gem.

Fixes #862

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3e7a7e5) 98.19% compared to head (507d14a) 98.20%.
Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #863   +/-   ##
=======================================
  Coverage   98.19%   98.20%           
=======================================
  Files          14       14           
  Lines         555      558    +3     
=======================================
+ Hits          545      548    +3     
  Misses         10       10           
Files Changed Coverage Δ
lib/inherited_resources/responder.rb 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tagliala
Copy link
Contributor

tagliala commented Nov 1, 2023

Any chance to rebase and also test the see_other status?

@a-nickol
Copy link
Author

a-nickol commented Nov 1, 2023

I am not quite sure if the change is compatible with e.g. active admin etc.

Inherited Resources is no longer actively maintained by the original author and has been transferred to the ActiveAdmin organization for maintenance. New feature requests are not encouraged.

Thus I stopped working on the merge request and switched to https://github.com/heartcombo/responders.

Even though Responders has its own bugs, e.g. heartcombo/responders#230.

@tagliala
Copy link
Contributor

tagliala commented Apr 3, 2024

Any chance to rebase, fix the rubocop offense, and add a spec for the :see_other case?

/cc @javierjulio

@a-nickol
Copy link
Author

a-nickol commented Apr 3, 2024

I will do the changes if there are any plans that they will be merged.

@javierjulio
Copy link
Member

The priority is that any change we do continues to work with ActiveAdmin as it did before since it doesn't support Turbo currently. Thank you.

@tagliala
Copy link
Contributor

Superseded by #918.

I'm in favor of this change, even if it would need a major version bump to stay conservative.

Thanks @a-nickol, your changes have been preserved in the other PR

@tagliala tagliala closed this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create & Update should return status code != 200 for failed requests
3 participants