Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 1.56.4 to 1.57.1 #882

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 24, 2023

Bumps rubocop from 1.56.4 to 1.57.1.

Release notes

Sourced from rubocop's releases.

RuboCop 1.57.1

Bug fixes

  • #12271: Fix a false positive for Lint/RedundantSafeNavigation when using snake case constant receiver. (@​koic)
  • #12265: Fix an error for Layout/MultilineMethodCallIndentation when usingarithmetic operation with block inside a grouped expression. (@​koic)
  • #12177: Fix an incorrect autocorrect for Style/RedundantException. (@​ydah)
  • #12261: Fix an infinite loop for Layout/MultilineMethodCallIndentation when multiline method chain with a block argument and method chain. (@​ydah)
  • #12263: Fix false positives for Style/RedundantDoubleSplatHashBraces when method call for no hash braced double splat receiver. (@​koic)
  • #12262: Fix an incorrect autocorrect for Style/RedundantDoubleSplatHashBraces when using double splat hash braces with merge method call twice. (@​koic)

RuboCop 1.57

New features

  • #12227: Add new Style/SingleLineDoEndBlock cop. (@​koic)
  • #12246: Make Lint/RedundantSafeNavigation aware of constant receiver. (@​koic)
  • #12257: Make Style/RedundantDoubleSplatHashBraces aware of merge methods. (@​koic)

Bug fixes

  • #12244: Fix a false negative for Lint/Debugger when using debugger method inside block. (@​koic)
  • #12231: Fix a false negative for Metrics/ModuleLength when defining a singleton class in a module. (@​koic)
  • #12249: Fix a false positive Style/IdenticalConditionalBranches when if..else with identical leading lines and assign to condition value. (@​koic)
  • #12253: Fix Lint/LiteralInInterpolation to accept an empty string literal interpolated in words literal. (@​knu)
  • #12198: Fix an error for flip-flop with beginless or endless ranges. (@​koic)
  • #12259: Fix an error for Lint/MixedCaseRange when using nested character class in regexp. (@​koic)
  • #12237: Fix an error for Style/NestedTernaryOperator when a ternary operator has a nested ternary operator within an if. (@​koic)
  • #12228: Fix false negatives for Style/MultilineBlockChain when using multiline block chain with safe navigation operator. (@​koic)
  • #12247: Fix false negatives for Style/RedundantParentheses when using logical or comparison expressions with redundant parentheses. (@​koic)
  • #12226: Fix false positives for Layout/MultilineMethodCallIndentation when aligning methods in multiline block chain. (@​koic)
  • #12076: Fixed an issue where the top-level cache folder was named differently during two consecutive rubocop runs. (@​K-S-A)

Changes

  • #12235: Enable auto parallel inspection when config file is specified. (@​aboutNisblee)
  • #12234: Enhance Style/FormatString's autocorrection when using known conversion methods whose return value is not an array. (@​koic)
  • #12128: Make Style/GuardClause aware of define_method. (@​koic)
  • #12126: Make Style/RedundantFilterChain aware of select.present? when ActiveSupportExtensionsEnabled config is true. (@​koic)
  • #12250: Mark Lint/RedundantRequireStatement as unsafe autocorrect. (@​koic)
  • #12097: Mark unsafe autocorrect for Style/ClassEqualityComparison. (@​koic)
  • #12210: Mark Style/RedundantFilterChain as unsafe autocorrect. (@​koic)
Changelog

Sourced from rubocop's changelog.

1.57.1 (2023-10-13)

Bug fixes

  • #12271: Fix a false positive for Lint/RedundantSafeNavigation when using snake case constant receiver. ([@​koic][])
  • #12265: Fix an error for Layout/MultilineMethodCallIndentation when usingarithmetic operation with block inside a grouped expression. ([@​koic][])
  • #12177: Fix an incorrect autocorrect for Style/RedundantException. ([@​ydah][])
  • #12261: Fix an infinite loop for Layout/MultilineMethodCallIndentation when multiline method chain with a block argument and method chain. ([@​ydah][])
  • #12263: Fix false positives for Style/RedundantDoubleSplatHashBraces when method call for no hash braced double splat receiver. ([@​koic][])
  • #12262: Fix an incorrect autocorrect for Style/RedundantDoubleSplatHashBraces when using double splat hash braces with merge method call twice. ([@​koic][])

1.57.0 (2023-10-11)

New features

  • #12227: Add new Style/SingleLineDoEndBlock cop. ([@​koic][])
  • #12246: Make Lint/RedundantSafeNavigation aware of constant receiver. ([@​koic][])
  • #12257: Make Style/RedundantDoubleSplatHashBraces aware of merge methods. ([@​koic][])

Bug fixes

  • #12244: Fix a false negative for Lint/Debugger when using debugger method inside block. ([@​koic][])
  • #12231: Fix a false negative for Metrics/ModuleLength when defining a singleton class in a module. ([@​koic][])
  • #12249: Fix a false positive Style/IdenticalConditionalBranches when if..else with identical leading lines and assign to condition value. ([@​koic][])
  • #12253: Fix Lint/LiteralInInterpolation to accept an empty string literal interpolated in words literal. ([@​knu][])
  • #12198: Fix an error for flip-flop with beginless or endless ranges. ([@​koic][])
  • #12259: Fix an error for Lint/MixedCaseRange when using nested character class in regexp. ([@​koic][])
  • #12237: Fix an error for Style/NestedTernaryOperator when a ternary operator has a nested ternary operator within an if. ([@​koic][])
  • #12228: Fix false negatives for Style/MultilineBlockChain when using multiline block chain with safe navigation operator. ([@​koic][])
  • #12247: Fix false negatives for Style/RedundantParentheses when using logical or comparison expressions with redundant parentheses. ([@​koic][])
  • #12226: Fix false positives for Layout/MultilineMethodCallIndentation when aligning methods in multiline block chain. ([@​koic][])
  • #12076: Fixed an issue where the top-level cache folder was named differently during two consecutive rubocop runs. ([@​K-S-A][])

Changes

  • #12235: Enable auto parallel inspection when config file is specified. ([@​aboutNisblee][])
  • #12234: Enhance Style/FormatString's autocorrection when using known conversion methods whose return value is not an array. ([@​koic][])
  • #12128: Make Style/GuardClause aware of define_method. ([@​koic][])
  • #12126: Make Style/RedundantFilterChain aware of select.present? when ActiveSupportExtensionsEnabled config is true. ([@​koic][])
  • #12250: Mark Lint/RedundantRequireStatement as unsafe autocorrect. ([@​koic][])
  • #12097: Mark unsafe autocorrect for Style/ClassEqualityComparison. ([@​koic][])
  • #12210: Mark Style/RedundantFilterChain as unsafe autocorrect. ([@​koic][])
Commits
  • 9141fe5 Cut 1.57.1
  • a302d0c Update Changelog
  • 12016d8 [Fix #12271] Fix a false positive for Lint/RedundantSafeNavigation
  • 128618c Fix false positives for Style/RedundantDoubleSplatHashBraces
  • 03cdf04 Merge pull request #12267 from ydah/fix/12261
  • 7edb5ca [Fix #12261] Fix an infinite loop for Layout/MultilineMethodCallIndentation
  • 42898bc Merge pull request #12266 from koic/fix_an_error_for_layout_multiline_method_...
  • a4a505d [Fix #12265] Fix an error for Layout/MultilineMethodCallIndentation
  • 84840b8 Fix typos
  • 873cb9f Fix an incorrect autocorrect for Style/RedundantException when message is n...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Oct 24, 2023
@github-actions github-actions bot enabled auto-merge (squash) October 24, 2023 23:10
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this patch or minor update.

@javierjulio javierjulio disabled auto-merge October 24, 2023 23:11
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-1.57.1 branch from 083ae0c to b38d085 Compare October 24, 2023 23:12
@github-actions github-actions bot enabled auto-merge (squash) October 24, 2023 23:13
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this patch or minor update.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f1060b3) 98.19% compared to head (8ab9b7a) 98.19%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #882   +/-   ##
=======================================
  Coverage   98.19%   98.19%           
=======================================
  Files          14       14           
  Lines         555      555           
=======================================
  Hits          545      545           
  Misses         10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-1.57.1 branch from b38d085 to 888c463 Compare October 24, 2023 23:14
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this patch or minor update.

@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-1.57.1 branch from 888c463 to 1cea172 Compare October 24, 2023 23:16
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this patch or minor update.

Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.56.4 to 1.57.1.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.56.4...v1.57.1)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-1.57.1 branch from 1cea172 to 8ab9b7a Compare October 24, 2023 23:21
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this patch or minor update.

@github-actions github-actions bot merged commit 426a223 into master Oct 24, 2023
@github-actions github-actions bot deleted the dependabot/bundler/rubocop-1.57.1 branch October 24, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants