Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dictionary based filtering for IN #2893

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Added dictionary based filtering for IN #2893

merged 3 commits into from
Jul 2, 2024

Conversation

istranical
Copy link
Contributor

@istranical istranical commented Jul 1, 2024

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • Added dictionary based filtering where if target is a list, it's compared via IN
  • Cleaned up tests slightly, and removed TQL string comparisons in some tests. The query results are either right or wrong, and should be assessed via output correctness. We likely shouldn't test string parsing or TQL syntax in the vector store module.

Things to be aware of

Things to worry about

Additional Context

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link

sonarcloud bot commented Jul 2, 2024

@nvoxland-al nvoxland-al merged commit fa20c2f into main Jul 2, 2024
9 of 10 checks passed
@nvoxland-al nvoxland-al deleted the improve_filter branch July 2, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants