Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Etihad GuestPay icon #1240

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Conversation

logeecom
Copy link
Contributor

Why are you adding this icons?

I'm adding/updating this icon because this is a new payment gateway for Shopify - approved under Partner account Pointspay.

Help us identify yourself

  • I'm working/collaborating with the brand directly and they have provided the icons.
  • I'm associated with the brand and I've read all the brand icon’s guidelines.
  • I'm an individual and I've read all the brand icon’s guidelines.

Link to the brand guidelines: https://pointspay.com/

Checklist to add new icons

  • All icons have a corresponding entry in db/payment_icons.yml
  • I have followed the icon guidelines detailed in the CONTRIBUTING.md file
  • I have optimized the icon with SVGO
  • I am confident that all icons are clear and easy to read/understand
  • I have provided a link to the brand icon’s brand guidelines whenever possible.
  • I have attached a screenshot comparison with the example icon provided in guidelines
  • I recognize that if my icon is not approved by the Shopify Partners team it may not receive review nor merger.

Attach a screenshot of the icon along side the example Visa icon

etihadguestpay

If the icons are intended for use by Shopify, please provide the following info:

Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
Payment partnership team

What's the expected date of this change to deploy on Shopify?
As soon as possible

@RogierJacobson
Copy link

can we get this one approved ?

@RogierJacobson
Copy link

Hi , @Lovedanihonjin can we get this one approved ? We are getting ready to launch our app and this image is an important element of it :) Thanks!

@RogierJacobson
Copy link

Goodmorning . Can we get this one approved? It's blocking our next steps now.

@dannye0231 dannye0231 merged commit 4c1415b into activemerchant:master Dec 4, 2024
8 checks passed
@RogierJacobson
Copy link

It seems the update is not working as we deployed the application with the newly added Etihad icon, but the validation issue still persists. Can you check if the logo was properly propagated ?

@dannye0231
Copy link
Contributor

Hi @RogierJacobson , we finally got everything merged across all repos yesterday. We ran into delays due to lockdowns during Black Friday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants