Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add World Chain #1241

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Add World Chain #1241

merged 3 commits into from
Dec 4, 2024

Conversation

10xSebastian
Copy link
Contributor

Why are you adding this icons?

I'm adding this icon as our DePay Payment App for Shopify has finished adding support for the the World Chain blockchain. We collaborate directly with Tools For Humanity, the company behind World Chain, which also selected the final logo for the payment icon.

Help us identify yourself

  • I'm working/collaborating with the brand directly and they have provided the icons.
  • I'm associated with the brand and I've read all the brand icon’s guidelines.
  • I'm an individual and I've read all the brand icon’s guidelines.

Link to the brand guidelines:

Checklist to add new icons

  • All icons have a corresponding entry in db/payment_icons.yml
  • I have followed the icon guidelines detailed in the CONTRIBUTING.md file
  • I have optimized the icon with SVGO
  • I am confident that all icons are clear and easy to read/understand
  • I have provided a link to the brand icon’s brand guidelines whenever possible.
  • I have attached a screenshot comparison with the example icon provided in guidelines
  • I recognize that if my icon is not approved by the Shopify Partners team it may not receive review nor merger.

Attach a screenshot of the icon along side the example Visa icon

Screenshot 2024-10-15 at 16 36 32

If the icons are intended for use by Shopify, please provide the following info:

We are working with the Shopify Payments team and our partnership manager was/is Domingo Meneses.

What's the expected date of this change to deploy on Shopify?
As soon as possible.

@dannye0231
Copy link
Contributor

Hi @0xNe0x1 are you able to look further into the following errors related to your SVG?

Failure:
PaymentIconTest#test_Every_payment_SVG_meets_accessibility_requirements [test/unit/payment_icon_test.rb:93]:
{:message=>"The 'worldchain' SVG file should have a 'role' attribute on the root tag"}

Failure:
PaymentIconTest#test_Every_payment_icon_SVG_has_a_viewBox_attribute [test/unit/payment_icon_test.rb:56]:
{:message=>"The 'worldchain' SVG file should have a 'viewBox' attribute on the root tag"}

@0xNe0x1
Copy link
Contributor

0xNe0x1 commented Oct 25, 2024

Thanks @dannye0231

I have added the role and viewBox attribute.

@dannye0231 dannye0231 merged commit ed1c39d into activemerchant:master Dec 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants