Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CBC payment icon #1243

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

danielcivit
Copy link
Contributor

Why are you adding this icons?

This icon is missing, and somehow the existing icon database suggests using the same one as KBC for CBC since this one uses a name that points to both brands.

That approach might be correct in the past but we think is not correct these days. MultiSafepay, offers KBC and CBC as different payment gateways. And when a customer select any of these payment methods, it will be redirected to different endpoints.

In the next step, maybe we can suggest deprecating the "kbc_cbc" payment icon, and provide another option named "kbc" to prevent confusion.

Help us identify yourself

  • I'm working/collaborating with the brand directly and they have provided the icons.
  • I'm associated with the brand and I've read all the brand icon’s guidelines.
  • I'm an individual and I've read all the brand icon’s guidelines.

Link to the brand guidelines:

Checklist to add new icons

  • All icons have a corresponding entry in db/payment_icons.yml
  • I have followed the icon guidelines detailed in the CONTRIBUTING.md file
  • I have optimized the icon with SVGO
  • I am confident that all icons are clear and easy to read/understand
  • I have provided a link to the brand icon’s brand guidelines whenever possible.
  • I have attached a screenshot comparison with the example icon provided in guidelines
  • I recognize that if my icon is not approved by the Shopify Partners team it may not receive review nor merger.

If this pull request is not adding new icons, you can remove this checklist.

Attach a screenshot of the icon along side the example Visa icon

comparison-4

Tips how to create a screenshot

We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.

<!-- Change background color if needed to showcase your icon better -->
<style> body { background: black; } </style>

<!-- DO NOT DELETE EXAMPLE -->
<svg viewBox="0 0 38 24" xmlns="http://www.w3.org/2000/svg" role="img" width="38" height="24" aria-labelledby="pi-visa"><title id="pi-visa">Visa</title><path opacity=".07" d="M35 0H3C1.3 0 0 1.3 0 3v18c0 1.7 1.4 3 3 3h32c1.7 0 3-1.3 3-3V3c0-1.7-1.4-3-3-3z"/><path fill="#fff" d="M35 1c1.1 0 2 .9 2 2v18c0 1.1-.9 2-2 2H3c-1.1 0-2-.9-2-2V3c0-1.1.9-2 2-2h32"/><path d="M28.3 10.1H28c-.4 1-.7 1.5-1 3h1.9c-.3-1.5-.3-2.2-.6-3zm2.9 5.9h-1.7c-.1 0-.1 0-.2-.1l-.2-.9-.1-.2h-2.4c-.1 0-.2 0-.2.2l-.3.9c0 .1-.1.1-.1.1h-2.1l.2-.5L27 8.7c0-.5.3-.7.8-.7h1.5c.1 0 .2 0 .2.2l1.4 6.5c.1.4.2.7.2 1.1.1.1.1.1.1.2zm-13.4-.3l.4-1.8c.1 0 .2.1.2.1.7.3 1.4.5 2.1.4.2 0 .5-.1.7-.2.5-.2.5-.7.1-1.1-.2-.2-.5-.3-.8-.5-.4-.2-.8-.4-1.1-.7-1.2-1-.8-2.4-.1-3.1.6-.4.9-.8 1.7-.8 1.2 0 2.5 0 3.1.2h.1c-.1.6-.2 1.1-.4 1.7-.5-.2-1-.4-1.5-.4-.3 0-.6 0-.9.1-.2 0-.3.1-.4.2-.2.2-.2.5 0 .7l.5.4c.4.2.8.4 1.1.6.5.3 1 .8 1.1 1.4.2.9-.1 1.7-.9 2.3-.5.4-.7.6-1.4.6-1.4 0-2.5.1-3.4-.2-.1.2-.1.2-.2.1zm-3.5.3c.1-.7.1-.7.2-1 .5-2.2 1-4.5 1.4-6.7.1-.2.1-.3.3-.3H18c-.2 1.2-.4 2.1-.7 3.2-.3 1.5-.6 3-1 4.5 0 .2-.1.2-.3.2M5 8.2c0-.1.2-.2.3-.2h3.4c.5 0 .9.3 1 .8l.9 4.4c0 .1 0 .1.1.2 0-.1.1-.1.1-.1l2.1-5.1c-.1-.1 0-.2.1-.2h2.1c0 .1 0 .1-.1.2l-3.1 7.3c-.1.2-.1.3-.2.4-.1.1-.3 0-.5 0H9.7c-.1 0-.2 0-.2-.2L7.9 9.5c-.2-.2-.5-.5-.9-.6-.6-.3-1.7-.5-1.9-.5L5 8.2z" fill="#142688"/></svg>

<!-- TODO: insert your icon here -->
<svg xmlns="http://www.w3.org/2000/svg" role="img" viewBox="0 0 38 24" fill="none" width="38" height="24" aria-labelledby="pi-cbc"><title id="pi-cbc">CBC</title><rect x="1" y="1" width="36" height="22" rx="2" fill="#fff"/><rect x=".5" y=".5" width="37" height="23" rx="2.5" stroke="#000" stroke-opacity=".07"/>&quot;/&gt;<path fill-rule="evenodd" clip-rule="evenodd" d="M19.047 5.019a3.091 3.091 0 11.114 6.18 3.091 3.091 0 01-.114-6.18z" fill="#009fe4"/><path fill-rule="evenodd" clip-rule="evenodd" d="M21.384 10.61a4.062 4.062 0 01-2.96 1.277 4.102 4.102 0 01-2.49-.849 71.189 71.189 0 00-5.883.856v1.367l17.9-.002v-2.817s-3.066-.02-6.567.168z" fill="#009fe4"/><path fill-rule="evenodd" clip-rule="evenodd" d="M27.952 18.737a6.386 6.386 0 01-1.752.244c-2.104 0-3.648-.598-3.648-2.337 0-1.572 1.497-2.255 3.543-2.255.57 0 1.292.063 1.857.244v1.522a2.586 2.586 0 00-1.438-.412c-.78 0-1.561.385-1.561.943 0 .559.777.942 1.56.942.59 0 1.02-.163 1.438-.405v1.514zm-12.504 0a6.386 6.386 0 01-1.751.244c-2.104 0-3.649-.598-3.649-2.337 0-1.572 1.497-2.255 3.544-2.255.568 0 1.29.063 1.856.244v1.522a2.586 2.586 0 00-1.438-.412c-.78 0-1.56.385-1.56.943 0 .559.776.942 1.56.942.59 0 1.019-.163 1.437-.405l.001 1.514zm.891-4.246h4.299c1.116 0 1.482.435 1.482 1.11 0 .757-.676 1.086-1.37 1.123v.013c.713.056 1.408.136 1.408 1.03 0 .583-.366 1.153-1.595 1.153H16.34v-4.429zm2.127 3.529h1.108c.416 0 .558-.172.558-.426 0-.255-.143-.437-.553-.437h-1.113v.863zm0-1.652h1.059c.41 0 .57-.165.57-.42 0-.291-.162-.437-.54-.437h-1.09v.857z" fill="#003664"/></svg>

<br>

If the icons are intended for use by Shopify, please provide the following info:

Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)

What's the expected date of this change to deploy on Shopify?

@danielcivit
Copy link
Contributor Author

Would it be possible to receive feedback for this PR and, ideally, an estimated time of when we could hope to have these payment method icons added or updated?

@danielcivit
Copy link
Contributor Author

Hi.

Would it be possible to receive feedback for this PR and, ideally, an estimated time of when we could hope to have these payment method icons added or updated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant