Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure TCP connection is properly shut down when Session is dropped #476

Merged
merged 3 commits into from
Dec 29, 2024
Merged

fix: ensure TCP connection is properly shut down when Session is dropped #476

merged 3 commits into from
Dec 29, 2024
+6 −0

Conversation

centromere
Copy link
Contributor

@centromere centromere commented Nov 1, 2024 •
edited by robjtede
Loading

PR Type

Bug fix

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the nightly rustfmt (cargo +nightly fmt).

Overview

When a Session falls out of scope, StreamingBody's poll_next ought to return Poll::Ready(None), not Poll::Pending.

Relates to: actix/actix-web#3093

@robjtede robjtede added B-semver-patch A-ws Project: actix-ws labels Dec 29, 2024
@robjtede robjtede enabled auto-merge December 29, 2024 16:52
@robjtede robjtede disabled auto-merge December 29, 2024 16:52
@robjtede robjtede changed the title Ensure TCP connection is properly shut down when Session is dropped fix: ensure TCP connection is properly shut down when Session is dropped Dec 29, 2024
@robjtede robjtede enabled auto-merge December 29, 2024 16:53
@robjtede robjtede added this pull request to the merge queue Dec 29, 2024
Merged via the queue into actix:master with commit 98847b9 Dec 29, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asonix asonix asonix approved these changes

@robjtede robjtede robjtede approved these changes

Assignees
No one assigned
Labels
A-ws Project: actix-ws B-semver-patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@centromere @robjtede @asonix