Skip to content

Wake Future when EOF is received #3492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

centromere
Copy link

PR Type

Bug fix

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

When a TCP FIN is received, the Future needs to be awakened. Without this, it is not possible to detect a connection closure in end-user applications.

Relates to: #3093

Copy link
Contributor

@asonix asonix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@robjtede robjtede added A-http project: actix-http B-semver-patch labels May 9, 2025
When a TCP FIN is received, the Future needs to be awakened. Without this, it
is not possible to detect a connection closure in end-user applications.
@centromere
Copy link
Author

@robjtede @asonix, may this get merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-http project: actix-http B-semver-patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants