-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement volume material propagation with SympyStepper
#4132
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
SympyStepper
|
Implements volume material propagation with proper continuous energy loss, energy loss uncertainty and multiple scattering. This required piping an additional covariance term through
CovarianceEngine
and the steppers which is modeled as astd::optional
for now. TheEigenStepper
was not changed for now and could be adapted similarly to theSympyStepper
.MaterialAccumulator
was added which is a tool to handle increasing material during the stepping. TheSympyStepper
gained another generated stepping function which deals with volume material. It automatically switches to this function when volume material is detected.