-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Deduplicate seeds after track selection in TrackFindingAlgorithm
in Examples
#4147
refactor: Deduplicate seeds after track selection in TrackFindingAlgorithm
in Examples
#4147
Conversation
WalkthroughRepositioned the code block that flags seeds in the Changes
Sequence Diagram(s)sequenceDiagram
participant AT as addTrack Lambda
participant TT as Track Trimming Logic
participant FS as Flagging Operation
participant DS as DiscoveredSeeds Map
AT->>TT: Execute track trimming
TT->>FS: Pass control for flagging seeds
FS->>DS: Update flag for seed identifiers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (25)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
📊: Physics performance monitoring for be5beafFull contents |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good to me! Approving.
This PR currently has a merge conflict. Please resolve this and then re-add the |
|
Currently we deduplicate seeds before tracks are selected during finding. This may lead to inefficiencies as other seeds might result in a selected track. This PR moves the deduplication after the selection.
Summary by CodeRabbit