Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Deduplicate seeds after track selection in TrackFindingAlgorithm in Examples #4147

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Mar 24, 2025

Currently we deduplicate seeds before tracks are selected during finding. This may lead to inefficiencies as other seeds might result in a selected track. This PR moves the deduplication after the selection.

Summary by CodeRabbit

  • Refactor
    • Reordered internal processing steps during track evaluation to maintain consistency without altering the overall functionality.
  • Tests
    • Updated reference values in regression tests to align with the internal adjustments.

@andiwand andiwand added this to the next milestone Mar 24, 2025
Copy link

coderabbitai bot commented Mar 24, 2025

Walkthrough

Repositioned the code block that flags seeds in the addTrack lambda, it has been. After the track trimming logic now the flagging occurs, updating the discovered seeds mapping, unchanged the overall functionality remains. Additionally, hash values in the test file have been updated for two track-related files. No modifications to public declarations there are, hmmm.

Changes

File Change Summary
Ex.../TrackFindingAlgorithm.cpp Code block repositioned in addTrack lambda to flag seeds immediately after track trimming logic.
Ex.../root_file_hashes.txt Updated hash values for trackstates_ckf.root and tracksummary_ckf.root entries.

Sequence Diagram(s)

sequenceDiagram
    participant AT as addTrack Lambda
    participant TT as Track Trimming Logic
    participant FS as Flagging Operation
    participant DS as DiscoveredSeeds Map
    AT->>TT: Execute track trimming
    TT->>FS: Pass control for flagging seeds
    FS->>DS: Update flag for seed identifiers
Loading

Poem

Reposition code, we did with care,
Seeds flagged true, a path laid bare.
Hashes updated through the night,
In our code base, the Force shines bright.
Change flows through the stars above,
Hmmm, a balance found in work we love!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4a4e1dd and 682a260.

📒 Files selected for processing (1)
  • Examples/Python/tests/root_file_hashes.txt (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • Examples/Python/tests/root_file_hashes.txt
⏰ Context from checks skipped due to timeout of 90000ms (25)
  • GitHub Check: CI Bridge / lcg_107: [alma9, clang19]
  • GitHub Check: merge-sentinel
  • GitHub Check: CI Bridge / lcg_107: [alma9, gcc14]
  • GitHub Check: CI Bridge / lcg_107: [alma9, gcc13]
  • GitHub Check: CI Bridge / lcg_106a: [alma9, clang16]
  • GitHub Check: CI Bridge / lcg_106a: [alma9, gcc14]
  • GitHub Check: CI Bridge / lcg_106a: [alma9, gcc13]
  • GitHub Check: CI Bridge / lcg_105: [alma9, gcc13]
  • GitHub Check: CI Bridge / lcg_105: [alma9, clang16]
  • GitHub Check: CI Bridge / linux_ubuntu_2404_clang19
  • GitHub Check: CI Bridge / build_gnn_tensorrt
  • GitHub Check: CI Bridge / linux_ubuntu_2204
  • GitHub Check: CI Bridge / build_linux_ubuntu
  • GitHub Check: CI Bridge / build_exatrkx
  • GitHub Check: CI Bridge / clang_tidy
  • GitHub Check: CI Bridge / build_exatrkx_cpu
  • GitHub Check: CI Bridge / build_exatrkx_cpu
  • GitHub Check: CI Bridge / clang_tidy
  • GitHub Check: unused_files
  • GitHub Check: missing_includes
  • GitHub Check: macos
  • GitHub Check: linux_ubuntu_extra (ubuntu2404_clang19, 20, clang++-19)
  • GitHub Check: linux_ubuntu
  • GitHub Check: linux_ubuntu_extra (ubuntu2204, 20, g++)
  • GitHub Check: build_debug

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Component - Examples Affects the Examples module Track Finding labels Mar 24, 2025
Copy link

github-actions bot commented Mar 24, 2025

📊: Physics performance monitoring for be5beaf

Full contents
🟥 summary not found!

@github-actions github-actions bot added Infrastructure Changes to build tools, continous integration, ... Changes Performance labels Mar 24, 2025
@andiwand andiwand marked this pull request as ready for review March 25, 2025 09:02
noemina
noemina previously approved these changes Mar 25, 2025
Copy link
Contributor

@noemina noemina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me! Approving.

@kodiakhq kodiakhq bot removed the automerge label Mar 25, 2025
Copy link
Contributor

kodiakhq bot commented Mar 25, 2025

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@andiwand andiwand requested a review from noemina March 26, 2025 06:12
@kodiakhq kodiakhq bot merged commit 55f6fb3 into acts-project:main Mar 26, 2025
51 of 52 checks passed
@andiwand andiwand deleted the trackfinding-dedup-seeds-after-track-selection branch March 26, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Performance Component - Examples Affects the Examples module Infrastructure Changes to build tools, continous integration, ... Track Finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants