simplefin should use formatPayeeName

src/app-gocardless/banks/american-express-aesudef1.js

@@ -1,8 +1,8 @@
 import {
   amountToInteger,
   sortByBookingDateOrValueDate,
-  formatPayeeName,
 } from '../utils.js';
+import { formatPayeeName } from '../../util/payee-name.js';
 
 /** @type {import('./bank.interface.js').IBank} */
 export default {

src/app-gocardless/banks/belfius_gkccbebb.js

@@ -1,5 +1,5 @@
 import Fallback from './integration-bank.js';
-import { formatPayeeName } from '../utils.js';
+import { formatPayeeName } from '../../util/payee-name.js';
 
 /** @type {import('./bank.interface.js').IBank} */
 export default {

src/app-gocardless/banks/bnp-be-gebabebb.js

@@ -2,8 +2,8 @@ import {
   sortByBookingDateOrValueDate,
   amountToInteger,
   printIban,
-  formatPayeeName,
 } from '../utils.js';
+import { formatPayeeName } from '../../util/payee-name.js';
 
 const SORTED_BALANCE_TYPE_LIST = [
   'closingBooked',

src/app-gocardless/banks/danskebank-dabno22.js

@@ -2,8 +2,8 @@ import {
   printIban,
   amountToInteger,
   sortByBookingDateOrValueDate,
-  formatPayeeName,
 } from '../utils.js';
+import { formatPayeeName } from '../../util/payee-name.js';
 
 /** @type {import('./bank.interface.js').IBank} */
 export default {

src/app-gocardless/banks/ing-ingddeff.js

@@ -1,4 +1,5 @@
-import { printIban, amountToInteger, formatPayeeName } from '../utils.js';
+import { printIban, amountToInteger } from '../utils.js';
+import { formatPayeeName } from '../../util/payee-name.js';
 
 /** @type {import('./bank.interface.js').IBank} */
 export default {

src/app-gocardless/banks/ing-pl-ingbplpw.js

@@ -1,4 +1,5 @@
-import { printIban, amountToInteger, formatPayeeName } from '../utils.js';
+import { printIban, amountToInteger } from '../utils.js';
+import { formatPayeeName } from '../../util/payee-name.js';
 
 /** @type {import('./bank.interface.js').IBank} */
 export default {

src/app-gocardless/banks/integration-bank.js

@@ -3,8 +3,8 @@ import {
   sortByBookingDateOrValueDate,
   amountToInteger,
   printIban,
-  formatPayeeName,
 } from '../utils.js';
+import { formatPayeeName } from '../../util/payee-name.js';
 
 const SORTED_BALANCE_TYPE_LIST = [
   'closingBooked',

src/app-gocardless/banks/mbank-retail-brexplpw.js

@@ -1,4 +1,5 @@
-import { printIban, amountToInteger, formatPayeeName } from '../utils.js';
+import { printIban, amountToInteger } from '../utils.js';
+import { formatPayeeName } from '../../util/payee-name.js';
 
 /** @type {import('./bank.interface.js').IBank} */
 export default {

src/app-gocardless/banks/norwegian-xx-norwnok1.js

@@ -2,8 +2,8 @@ import {
   printIban,
   amountToInteger,
   sortByBookingDateOrValueDate,
-  formatPayeeName,
 } from '../utils.js';
+import { formatPayeeName } from '../../util/payee-name.js';
 
 /** @type {import('./bank.interface.js').IBank} */
 export default {

src/app-gocardless/banks/sandboxfinance-sfin0000.js

@@ -2,8 +2,8 @@ import {
   printIban,
   amountToInteger,
   sortByBookingDateOrValueDate,
-  formatPayeeName,
 } from '../utils.js';
+import { formatPayeeName } from '../../util/payee-name.js';
 
 /** @type {import('./bank.interface.js').IBank} */
 export default {

src/app-gocardless/banks/seb-kort-bank-ab.js

@@ -2,8 +2,8 @@ import {
   printIban,
   amountToInteger,
   sortByBookingDateOrValueDate,
-  formatPayeeName,
 } from '../utils.js';
+import { formatPayeeName } from '../../util/payee-name.js';
 
 /** @type {import('./bank.interface.js').IBank} */
 export default {

src/app-gocardless/banks/seb-privat.js

@@ -3,8 +3,8 @@ import {
   sortByBookingDateOrValueDate,
   amountToInteger,
   printIban,
-  formatPayeeName,
 } from '../utils.js';
+import { formatPayeeName } from '../../util/payee-name.js';
 
 /** @type {import('./bank.interface.js').IBank} */
 export default {

src/app-gocardless/banks/sparnord-spnodk22.js

@@ -2,8 +2,8 @@ import {
   sortByBookingDateOrValueDate,
   amountToInteger,
   printIban,
-  formatPayeeName,
 } from '../utils.js';
+import { formatPayeeName } from '../../util/payee-name.js';
 
 const SORTED_BALANCE_TYPE_LIST = [
   'closingBooked',

src/app-gocardless/banks/spk-karlsruhe-karsde66.js

@@ -2,8 +2,8 @@ import {
   printIban,
   amountToInteger,
   sortByBookingDateOrValueDate,
-  formatPayeeName,
 } from '../utils.js';
+import { formatPayeeName } from '../../util/payee-name.js';
 
 /** @type {import('./bank.interface.js').IBank} */
 export default {

src/app-gocardless/banks/spk-marburg-biedenkopf-heladef1mar.js

@@ -2,8 +2,8 @@ import {
   printIban,
   amountToInteger,
   sortByBookingDateOrValueDate,
-  formatPayeeName,
 } from '../utils.js';
+import { formatPayeeName } from '../../util/payee-name.js';
 import d from 'date-fns';
 
 const SORTED_BALANCE_TYPE_LIST = [

src/app-gocardless/utils.js

@@ -1,9 +1,3 @@
-import { title } from './util/title/index.js';
-
-function formatPayeeIban(iban) {
-  return '(' + iban.slice(0, 4) + ' XXX ' + iban.slice(-4) + ')';
-}
-
 export const printIban = (account) => {
   if (account.iban) {
     return '(XXX ' + account.iban.slice(-4) + ')';
@@ -20,40 +14,3 @@ export const sortByBookingDateOrValueDate = (transactions = []) =>
   );
 
 export const amountToInteger = (n) => Math.round(n * 100);
-
-export const formatPayeeName = (trans) => {
-  const nameParts = [];
-
-  // get the correct name and account fields for the transaction amount
-  let name;
-  let account;
-  if (trans.amount > 0 || Object.is(Number(trans.amount), 0)) {
-    name = trans.debtorName;
-    account = trans.debtorAccount;
-  } else {
-    name = trans.creditorName;
-    account = trans.creditorAccount;
-  }
-
-  // use the correct fields for the amount if it was found
-  // if not, use whatever we can find
-  name =
-    name ||
-    trans.debtorName ||
-    trans.creditorName ||
-    trans.remittanceInformationUnstructured ||
-    (trans.remittanceInformationUnstructuredArray || []).join(', ') ||
-    trans.additionalInformation;
-
-  account = account || trans.debtorAccount || trans.creditorAccount;
-
-  if (name) {
-    nameParts.push(title(name));
-  }
-
-  if (account && account.iban) {
-    nameParts.push(formatPayeeIban(account.iban));
-  }
-
-  return nameParts.join(' ');
-};

src/app-simplefin/app-simplefin.js

@@ -2,6 +2,7 @@ import express from 'express';
 import { inspect } from 'util';
 import https from 'https';
 import { SecretName, secretsService } from '../services/secrets-service.js';
+import { formatPayeeName } from '../util/payee-name.js';
 
 const app = express();
 export { app as handlers };
@@ -109,8 +110,7 @@ app.post('/transactions', async (req, res) => {
         .split('T')[0];
 
       newTrans.date = new Date(dateToUse * 1000).toISOString().split('T')[0];
-      newTrans.payeeName = trans.payee;
-      //newTrans.debtorAccount = don't have compared to GoCardless
+      newTrans.payeeName = formatPayeeName(trans);
       newTrans.remittanceInformationUnstructured = trans.description;
       newTrans.transactionAmount = { amount: trans.amount, currency: 'USD' };
       newTrans.transactionId = trans.id;

src/util/payee-name.js

@@ -0,0 +1,42 @@
+import { title } from './title/index.js';
+
+function formatPayeeIban(iban) {
+  return '(' + iban.slice(0, 4) + ' XXX ' + iban.slice(-4) + ')';
+}
+
+export const formatPayeeName = (trans) => {
+  const nameParts = [];
+
+  // get the correct name and account fields for the transaction amount
+  let name;
+  let account;
+  if (trans.amount > 0 || Object.is(Number(trans.amount), 0)) {
+    name = trans.debtorName;
+    account = trans.debtorAccount;
+  } else {
+    name = trans.creditorName;
+    account = trans.creditorAccount;
+  }
+
+  // use the correct fields for the amount if it was found
+  // if not, use whatever we can find
+  name =
+    name ||
+    trans.debtorName ||
+    trans.creditorName ||
+    trans.remittanceInformationUnstructured ||
+    (trans.remittanceInformationUnstructuredArray || []).join(', ') ||
+    trans.additionalInformation;
+
+  account = account || trans.debtorAccount || trans.creditorAccount;
+
+  if (name) {
+    nameParts.push(title(name));
+  }
+
+  if (account && account.iban) {
+    nameParts.push(formatPayeeIban(account.iban));
+  }
+
+  return nameParts.join(' ');
+};