Refactor to add strict type comparisons and remove unnecessary else blocks #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-fidd
commented
Apr 19, 2024
| } else { | ||
| return null; | ||
| if (!confirmed) { | ||
| return { error: 'invalid-password' }; |
There was a problem hiding this comment.
This is the only functional change in this PR, if the password is incorrect the server will return invalid-password, not null.
trafico-bot
bot
added
✅ Approved
trafico-bot
bot
added
✨ Merged
joewashear007
pushed a commit
to joewashear007/actual-server
that referenced
this pull request
Apr 22, 2024
MMichotte
pushed a commit
to MMichotte/actual-server
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.