fill in creditor name for BNP bank transactions #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, this is a PR related to issue #347. Based on the transactions I have, this seems to work. If a case occurs that isn't handled by the rules I added, it should fall back to the existing processing. I'm not very used to writing JavaScript so please excuse any less-than-ideal syntax. |
|
Also, it looks like this change poses no problems when re-processing transactions that have already been synced before, but now with a different creditorName. I suppose the GoCardless sync code is already intelligent enough to filter that out. |
|
@CharlieMK @feliciaan |
MatissJanis
approved these changes
May 16, 2024
trafico-bot
bot
added
the
✅ Approved
trafico-bot
bot
added
✨ Merged
1 task
MMichotte
pushed a commit
to MMichotte/actual-server
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure payee names don't contain transactional information when pulling in transactions from BNP bank with GoCardless.