Extend bank adapter for SEB Kort #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakoblover
changed the title
Updated starting balance function
|
@walleb if you are still around - would you mind taking a peak at this PR? It slightly changes the existing SEB bank mapper. I wouldn't want things to break for you. On my end this looks good to go 👍 |
Looks good to me. Not sure how I missed the "nonInvoiced" balance type when I tested my PR. Maybe I didn't had any such transactions at that time. 👍 |
MMichotte
pushed a commit
to MMichotte/actual-server
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SEB_KORT_AB_NO_SKHSFI21behaves likeSEB_KORT_AB_SE_SKHSFI21. AddedSEB_KORT_AB_NO_SKHSFI21to the list of institutions in the bank adapter for SEB Kort.I'm not able to get the correct starting balance. It seems like the transactions array does not include the non-invoiced transactions, only the booked transactions. In the overview of transactions, however, the non-invoiced transactions are listed. The starting balance is missing the amount equivalent of the non-invoiced transactions. Could use some help here.Seems like I am able to get the correct starting balance after all. I had to connect the accont to gocardless again for it to recalculate the starting balance.