Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SANTANDER_BSCHESMM to banks with limited history #418

Conversation

sarfios20
Copy link
Contributor

Added Banco Santander (Spain) to the list of banks with limited history

@actual-github-bot actual-github-bot bot changed the title Add SANTANDER_BSCHESMM to banks with limited history [WIP] Add SANTANDER_BSCHESMM to banks with limited history Aug 10, 2024
@sarfios20
Copy link
Contributor Author

this works on my machine :)

@sarfios20 sarfios20 changed the title [WIP] Add SANTANDER_BSCHESMM to banks with limited history Add SANTANDER_BSCHESMM to banks with limited history Aug 10, 2024
@matt-fidd
Copy link
Contributor

Hi! Thank you for the contribution.

What error were you coming across to make this change please?

@sarfios20
Copy link
Contributor Author

Hi! When I linked my bank account, I would get an error while trying to sync the transaction data. I opened a ticket with GoCardless support and they determined that the issue was that max_historical_days was set to 730 days but my bank allowed only 90 days.

Poking around the repo I found #355 which dealt with this specific issue. By adding the bank's ID to the list of banks with limited history, the issue is fixed and I can now access that data on my tests.

@matt-fidd matt-fidd merged commit a879960 into actualbudget:master Aug 15, 2024
7 checks passed
MMichotte pushed a commit to MMichotte/actual-server that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants