Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GoCardless remittanceInformationStructured for notes if available #2760

Closed

Conversation

matt-fidd
Copy link
Contributor

@matt-fidd matt-fidd commented May 15, 2024

Closes #2759

Following a discussion in Discord it looks like BELADEBEXXX does not provide remittanceInformationUnstructured at all and just returns remittanceInformationStructured. The notes field should pick this up if it exists.

The GoCardless docs are vague on what this field contains and I can't seem to find the structure mentioned in them but (at least in this case) the data appears similar or the same to what we'd normally see in the unstructured version.

image

If #2721 and actualbudget/actual-server#353 are merged there's probably another conversation to be had regarding whether it's worth moving this over to actual-server too.

@github-actions github-actions bot changed the title Use GoCardless remittanceInformationStructured for notes if available [WIP] Use GoCardless remittanceInformationStructured for notes if available May 15, 2024
Copy link

netlify bot commented May 15, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 2ccea5f
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/6645397f83400a0007878c10
😎 Deploy Preview https://deploy-preview-2760.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented May 15, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.71 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 59.97 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/AppliedFilters.js 20.54 kB 0%
static/js/wide.js 261.78 kB 0%
static/js/ReportRouter.js 1.23 MB 0%
static/js/index.js 3 MB 0%

Copy link
Contributor

github-actions bot commented May 15, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB → 1.2 MB (+92 B) +0.01%
Changeset
File Δ Size
packages/loot-core/src/server/accounts/sync.ts 📈 +106 B (+0.47%) 22.04 kB → 22.14 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
kcab.worker.js 1.2 MB → 1.2 MB (+92 B) +0.01%

Smaller

No assets were smaller

Unchanged

No assets were unchanged

@trafico-bot trafico-bot bot added 🚧 WIP and removed 🚧 WIP labels May 15, 2024
@matt-fidd matt-fidd changed the title [WIP] Use GoCardless remittanceInformationStructured for notes if available Use GoCardless remittanceInformationStructured for notes if available May 15, 2024
@matt-fidd matt-fidd changed the title Use GoCardless remittanceInformationStructured for notes if available [WIP] Use GoCardless remittanceInformationStructured for notes if available May 15, 2024
@matt-fidd matt-fidd changed the title [WIP] Use GoCardless remittanceInformationStructured for notes if available Use GoCardless remittanceInformationStructured for notes if available May 15, 2024
@matt-fidd matt-fidd changed the title Use GoCardless remittanceInformationStructured for notes if available [WIP] Use GoCardless remittanceInformationStructured for notes if available May 15, 2024
@matt-fidd matt-fidd changed the title [WIP] Use GoCardless remittanceInformationStructured for notes if available Use GoCardless remittanceInformationStructured for notes if available May 15, 2024
@matt-fidd matt-fidd force-pushed the remittance-structured branch from 7259578 to 34d4523 Compare May 15, 2024 22:25
@MatissJanis
Copy link
Member

Lets put this one on hold until we get to an agreement in actualbudget/actual-server#353.

I'll try to review it soon™️.

@Peccadilloz
Copy link

As suggested by @kyrias on the Discord support channel I instead added the integration for this bank using the bank integration support. It's in the PR #358 over on the actual-server repo.

@matt-fidd
Copy link
Contributor Author

No problem, will close this one off

@matt-fidd matt-fidd closed this May 16, 2024
@matt-fidd
Copy link
Contributor Author

@MatissJanis looks like this field might not be what I thought it was. It's still possible we might want to use this as a fallback though, I've closed it off for now but let me know if you'd like it reopened.

@matt-fidd matt-fidd deleted the remittance-structured branch July 8, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants