-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GoCardless remittanceInformationStructured for notes if available #2760
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged No assets were unchanged |
7259578
to
34d4523
Compare
Lets put this one on hold until we get to an agreement in actualbudget/actual-server#353. I'll try to review it soon™️. |
No problem, will close this one off |
@MatissJanis looks like this field might not be what I thought it was. It's still possible we might want to use this as a fallback though, I've closed it off for now but let me know if you'd like it reopened. |
Closes #2759
Following a discussion in Discord it looks like
BELADEBEXXX
does not provideremittanceInformationUnstructured
at all and just returnsremittanceInformationStructured
. The notes field should pick this up if it exists.The GoCardless docs are vague on what this field contains and I can't seem to find the structure mentioned in them but (at least in this case) the data appears similar or the same to what we'd normally see in the unstructured version.
If #2721 and actualbudget/actual-server#353 are merged there's probably another conversation to be had regarding whether it's worth moving this over to
actual-server
too.