-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document multi-user usage of same budget file #496
Conversation
✅ Deploy Preview for actualbudget-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
docs/experimental/multi-user.md
Outdated
# Multi-user | ||
|
||
:::warning | ||
This is an **experimental feature**. That means we’re still working on finishing it. There may be bugs, missing functionality or incomplete documentation, and we may decide to remove the feature in a future release. If you have any feedback, please [open an issue](https://github.com/actualbudget/actual/issues) or post a message in the Discord. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an **experimental feature**. That means we’re still working on finishing it. There may be bugs, missing functionality or incomplete documentation, and we may decide to remove the feature in a future release. If you have any feedback, please [open an issue](https://github.com/actualbudget/actual/issues) or post a message in the Discord. | |
This is an **experimental feature**, which means we’re still working on finishing it. There may be bugs, missing functionality, or incomplete documentation, and we may decide to remove the feature in a future release. If you have any feedback, please [open an issue](https://github.com/actualbudget/actual/issues) or post a message in Discord. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just copied this section from one of the other experimental pages, so maybe fix them all in one (separate) PR? Also see below... sounds like we might want to move this out of "Experimental" altogether since it isn't like the other actually checkbox-toggled experimental features.
@matt-fidd good call, will do. |
Do you prefer commits squashed or as-is? |
As-is is fine, we squash merge anyway |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you! Will let @RubenOlsen have the final say before it goes in
With official multi-user support now in Actual as an experimental feature I think this might be confusing to have in the docs as-is. I'd be happy to have it in if the multi user section was dropped, and the text was moved into the block where the link is currently |
|
||
## Multi-user Support | ||
|
||
The same budget file may be opened and edited simultaneously from two separate browsers, even by two different people on different client computers. This should work unless the edits conflict. To be safe, avoid simultaneous usage of the same budget file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could the section here be removed and the text moved into joint-accounts.md
where the link is currently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest leaving it here (to get it out the door) - but also have a variant of the same in the joint accounts.md file. If you agree, @matt-fidd, I further suggest opening an enhancement request. There is no shame in repeating ourself (a little bit).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine either way, FWIW
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest leaving it here (to get it out the door) - but also have a variant of the same in the joint accounts.md file. If you agree, @matt-fidd, I further suggest opening an enhancement request. There is no shame in repeating ourself (a little bit).
Yeah, let's leave it here for now. We can revisit when proper multi user is released first party
Discussed in:
Could someone with intimate knowledge of the syncing architecture/CRDTs/etc. validate and help me perfect the text? I took the conservative approach with my "To be safe..." comment, but if it truly is fine to edit simultaneously, we should say so less conservatively. Moreso, if simultaneous edits are supported behavior, we should also take this page out of "experimental".