Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support putting config dir in $XDG_CONFIG_HOME #308

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Support putting config dir in $XDG_CONFIG_HOME #308

wants to merge 2 commits into from
+9 −6

Conversation

twio142
Copy link

@twio142 twio142 commented Sep 30, 2024

Regarding #208

I just patched where ever $HOME/.battery is found in the code.

Basically it checks whether the env var XDG_CONFIG_HOME is set. If so, set the config dir to $XDG_CONFIG_HOME/battery, otherwise fallback to $HOME/.battery.

Tell me if I'm missing something :)

@tim25651
Copy link

  1. Wouldn't you rather set the default location to $HOME/.config as stated in the specs at https://specifications.freedesktop.org/basedir-spec/latest/?
  2. XDG_CONFIG_HOME should be ignored in my opinion, if the script is used as setup for another user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twio142 @tim25651