consistent types in results #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yveshauser
added a commit
to IntersectMBO/plutus
that referenced
this pull request
Sep 9, 2021
awkure
pushed a commit
to mlabs-haskell/plutus
that referenced
this pull request
Sep 15, 2021
yveshauser
added a commit
to IntersectMBO/plutus
that referenced
this pull request
Sep 23, 2021
jonesnoaht
pushed a commit
to jonesnoaht/plutus
that referenced
this pull request
Oct 8, 2021
jonesnoaht
pushed a commit
to jonesnoaht/plutus
that referenced
this pull request
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the JSON files the types in the results are not consistent. payoff, notionalPrincipal, nominalInterestRate and accruedInterest are in some cases of type string and in other cases of type number within the same file. I converted the string occurrences to numbers for the NAM and ANN test-cases (PAM and LAM are fine).
Thanks!