Protect box ids access, Bump libosmium version #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… hopefully, this is the cause for the heisensegfault we occasionally observe
patrickbr
changed the title
lehmann-4178656ch
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the stuff added during the debug process for #80 that we should keep in master. This mainly includes some safeguards in
areaInAreaApproxandboxIdIsectwhich explicitly catch and handle situations that should never happen, but might.I also bumped the
libosmiumversion to v2.20.0Note that the segfaults in #80 were not related to these changes. The reason for them is still unknown, but they were only reproducible with Boost 1.78, not with previous or later versions.