For the MULTI_INPUT_JSON value, also allow JSONL
#91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, `MULTI_INPUT_JSON` had to be a JSON string. When producing the string programatically for a large number of directories or files, that can be a bit annoying because of the leading `[` and trailing `]` and the separating commas. To make this easier, the string may now also be in JSONL format (one JSON per line). It will then simply be transformed to a JSON array in the obvious way. As a proof of concept and as an example, the Qleverfile for DBLP was adapted accordingly.
hannahbast
changed the title
MULTI_INPUT_JSON also allow JSONLMULTI_INPUT_JSON value, also allow JSONL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far,
MULTI_INPUT_JSONhad to be a JSON string. When producing the string programatically for a large number of directories or files, that can be cumbersome because of the leading[and trailing]and the separating commas.To make this easier, the string may now also be in JSONL format (one JSON per line). It will then simply be transformed to a JSON array in the obvious way.
As a proof of concept and as an example, the Qleverfile for DBLP is adapted accordingly.