If command was not successful, exit with code 1, ENHANCEMENTS #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qup42
requested changes
Dec 6, 2024
There was a problem hiding this comment.
Tested it out and it works so far. As we're making the exit code more consistent right now, I raised some points that also fall under that umbrella. If the current behavior is intentional, you can just ignore that point.
StatusCommand::executeis missing a return statement at the end of the function. this results in an incorrect exit code (this is also the cause for the job failure)stop.py::103is stop unsuccessful if nothing was running? I would argue that stop is successful iff all running processes/containers of the current Qleverfile were stopped. If none are running, then stop is successful.- (unimportant)
LogCommand::excute::56the exit code ofsubprocess.callcould be checked add_text_index.py::70failure testing if the binary exists and works is ignoredclear_cache.py::79the return of callingCacheStatsCommandis ignoredexample_queries.py::233return value ofClearCacheCommandis ignored (though this seems intential due to the log muting)start.py::75return of callingStopCommandis ignoredstart.py::192failure setting the index description is ignoredstart.py::203failure setting the text description is ignoredstart.py::212return callingWarmupCommandis ignoredstop.py::76failure getting process info is ignored (though this looks ok to me; the failure seems to not be critical)
src/qlever/commands/index_stats.py
Outdated
Comment on lines
270
to
273
| if not args.show: | ||
| ret_value &= self.execute_space(args) | ||
|
|
||
| return ret_value | ||
| return True |
There was a problem hiding this comment.
This breaks the command. The &= no longer work, because the variable is not defined before. The return values of execute_space and execute_time are also ignored.
hannahbast
changed the title
|
@Qup42 Thanks a lot for the very useful suggestions, I considered them all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancing the earlier (accidental) commit df63614 which already contained the core of this change