Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make output for results with zero columns standard-compliant #1749

Merged
merged 2 commits into from
Feb 9, 2025

Conversation

hannahbast
Copy link
Member

@hannahbast hannahbast commented Jan 31, 2025

For queries with zero columns (e.g., SELECT * WHERE { <s> <p> <o> }), the results were not fully standard-compliant. In particular, only the empty header row was output for text/tab-separated-values and text/csv, but never any additional empty rows. This is now fixed. Fixes #1745

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.97%. Comparing base (f2562fe) to head (953a7c8).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
src/engine/ExportQueryExecutionTrees.cpp 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1749      +/-   ##
==========================================
+ Coverage   89.95%   89.97%   +0.02%     
==========================================
  Files         395      395              
  Lines       37651    37654       +3     
  Branches     4234     4234              
==========================================
+ Hits        33869    33880      +11     
+ Misses       2487     2478       -9     
- Partials     1295     1296       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hannahbast hannahbast changed the title Output empty lines in TSV and CSV export Make output for results with zero columns standard-compliant Jan 31, 2025
@sparql-conformance
Copy link

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much

@joka921
Copy link
Member

joka921 commented Feb 5, 2025

For queries with zero columns (e.g., SELECT * WHERE { <s> <p> <o> }), the results were not fully standard-compliant. In particular, only the empty header row was output for text/tab-separated-values and text/csv, but never any additional empty rows. This is now fixed. Fixes #1745

@hannahbast hannahbast merged commit 79449fd into master Feb 9, 2025
22 of 24 checks passed
hannahbast pushed a commit that referenced this pull request Feb 10, 2025
…ql-results+json`

PR #1749 fixed this for `application/csv` and `application/tab-separated-values`, now
it is also fixed for `application/sparql-results+json`. Fixes #1745 (again).
hannahbast added a commit that referenced this pull request Feb 11, 2025
…ql-results+json` (#1793)

Pull request #1749 fixed this for `application/csv` and `application/tab-separated-values`, now it is also fixed for `application/sparql-results+json`. Fixes the remaining part of #1745
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output for result with zero columns not standard-compliant
2 participants