Allow ; after update request with a single operation
#1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1750 +/- ##
=======================================
Coverage 89.95% 89.95%
=======================================
Files 395 395
Lines 37651 37651
Branches 4234 4234
=======================================
Hits 33869 33869
+ Misses 2487 2484 -3
- Partials 1295 1298 +3 ☔ View full report in Codecov by Sentry. |
hannahbast
changed the title
; after an Update; after update request with a single operation
hannahbast
approved these changes
Feb 1, 2025
Conformance check passed ✅No test result changes. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QLever does not yet support update requests with more than one operation, e.g.,
DELETE DATA { <pi> <value> 3.14 }; INSERT DATA { <pi> <value> 3.1459 }. Due to an oversight, the current implementation also did not support single operations followed by a semicolon, e.g.,DELETE DATA { <pi> <value> 3.14 };. These are now supported. Fixes #1747NOTE: Support for multiple operations in a single update request will be added soon.