Make the request body limit configurable (and increase the default)

[hannahbast]

There is now a runtime parameter request-body-limit with a default size of 100 MB. Previously, the implicit limit of Boost's http::request was used, which was 1 MB. When sending large requests via curl use a call like this:

curl -s localhost:7001 -H "Authorization: Bearer bla" -H "Content-type: application/sparql-update" --data-binary @file_with_insert_data > update-result.json

Sending an INSERT DATA currently takes around 40 second per one million triples, which is rather slow because the triples are parsed using the SPARQL parser. They should rather be parser with our RDF parser, which is work for a separate PR. See also #1756 (comment)

[codecov]

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.18%. Comparing base (dffbc2b) to head (ced8150).

Files with missing lines	Patch %	Lines
src/util/http/HttpServer.h	87.50%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1762      +/-   ##
==========================================
- Coverage   90.18%   90.18%   -0.01%     
==========================================
  Files         399      399              
  Lines       38374    38381       +7     
  Branches     4293     4294       +1     
==========================================
+ Hits        34608    34613       +5     
+ Misses       2473     2470       -3     
- Partials     1293     1298       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[RobinTF]

@hannahbast This seems to be a duplicate of #1089

[RobinTF]

This header is very expensive to include. It would be nice if the implementation could be moved into a cpp file

[Qup42]

Thanks for having a look. The HttpServer.h header is now only included in Server.cpp so that shouldn't be that much of a problem. The HttpServer unfortunately cannot be moved to a cpp, because the whole class is templated.

[RobinTF]

That's fine too but I was thinking about adding a helper function in a cpp and using it to call the function indirectly

[hannahbast]

1-1 with Julian, we tested this quite a bit and it works. Some minor suggestions:

1. Error handling when body limit is exceeded (right now the request does nothing and sends an empty reply)
2. Increase the default limit from 1 MB to 100 MB
3. Move the #include of util/http/HttpServer.h from Server.h to Server.cpp
4. Abbreviate large updates in the returned JSON (this is probably a PR on its own)
5. Fix copyright note at the top of HttpServer.h

[sparql-conformance]

Conformance check passed ✅

No test result changes.

Details: https://qlever.cs.uni-freiburg.de/sparql-conformance-ui?cur=ced8150ff088778ebd2579e9ce411f4758b2493f&prev=dffbc2babf8c95df77be877b46f34e7832f795ae

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud