Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test (__tests__ dir and .github/workflows): propose to implement unittests and automation #3

Closed
KemingHe opened this issue Jul 26, 2024 · 2 comments
Assignees
Labels

Comments

@KemingHe
Copy link
Contributor

KemingHe commented Jul 26, 2024

Request Form

@ad1992

Issue

Current yarn test script gives placeholder echo statement in package.json

Request

Implement automated unittesting through vitest and GitHub Actions to run per PR and merge (push) to main, aligning with project setup.

Reason

I want to use this package and I want future versions to be bug-free when I npm update.

Plan

  1. Accept this issue.
  2. Assign @KemingHe , tag as test.
  3. I will open a PR with ONLY adding the testing automation by end of day 07/26.
  4. Review, refactor or merge, and apply this issue as simple default issue template if you want.

Edit: grammar

@ad1992
Copy link
Owner

ad1992 commented Jul 26, 2024

@KemingHe sure please go ahead and raise the PR

@KemingHe
Copy link
Contributor Author

KemingHe commented Jul 26, 2024

@ad1992 Delivered and revised in #8. Edit: update status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants