ssh inspiration board - Shelby, Shayla, and Hope #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Shayla L <[email protected]> Co-authored-by: Hope Olaidé <[email protected]>
|
|
||
| const kBaseUrl = "https://ssh-back-end-inspiration-board.herokuapp.com"; | ||
|
|
||
| const boardApiToJson = (board) => { |
There was a problem hiding this comment.
Nice function to convert the network response!
Comment on lines
+46
to
+76
| if (sortType === "idDown") { | ||
| const idDescending = unsortedCardDataCopy.sort( | ||
| (a, b) => b.cardId - a.cardId | ||
| ); | ||
| return idDescending; | ||
| } else if (sortType === "idUp") { | ||
| const idAscending = unsortedCardDataCopy.sort( | ||
| (a, b) => a.cardId - b.cardId | ||
| ); | ||
| return idAscending; | ||
| } else if (sortType === "messageDown") { | ||
| const msgDescending = unsortedCardDataCopy.sort((a, b) => | ||
| a.message > b.message ? -1 : 1 | ||
| ); | ||
| return msgDescending; | ||
| } else if (sortType === "messageUp") { | ||
| const msgAscending = unsortedCardDataCopy.sort((a, b) => | ||
| a.message > b.message ? 1 : -1 | ||
| ); | ||
| return msgAscending; | ||
| } else if (sortType === "plusOneDown") { | ||
| const likesDescending = unsortedCardDataCopy.sort( | ||
| (a, b) => b.likesCount - a.likesCount | ||
| ); | ||
| return likesDescending; | ||
| } else if (sortType === "plusOneUp") { | ||
| const likesAscending = unsortedCardDataCopy.sort( | ||
| (a, b) => a.likesCount - b.likesCount | ||
| ); | ||
| return likesAscending; | ||
| } |
There was a problem hiding this comment.
When you have long if/else trees whose conditions are looking to match something particular, a switch statement can be a good replacement: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/switch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.