Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Otters - Jodi Denney #98

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 112 additions & 4 deletions src/adagrams.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,123 @@
// import { LETTER_POOL } from "../test/adagrams.test";
const LETTER_POOL = {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great use of the JS constant variable here at the top of the file! ✨

A: 9,
B: 2,
C: 2,
D: 4,
E: 12,
F: 2,
G: 3,
H: 2,
I: 9,
J: 1,
K: 1,
L: 4,
M: 2,
N: 6,
O: 8,
P: 2,
Q: 1,
R: 6,
S: 4,
T: 6,
U: 4,
V: 2,
W: 2,
X: 1,
Y: 2,
Z: 1,
};

const LETTER_SCORE = {
A: 1,
B: 3,
C: 3,
D: 2,
E: 1,
F: 4,
G: 2,
H: 4,
I: 1,
J: 8,
K: 5,
L: 1,
M: 3,
N: 1,
O: 1,
P: 3,
Q: 10,
R: 1,
S: 1,
T: 1,
U: 1,
V: 4,
W: 4,
X: 8,
Y: 4,
Z: 10,
};

export const drawLetters = () => {
// Implement this method for wave 1
const hand = [];
const letterBank = [];
// Build a letterBank array where each letters appearance is accurately weighted
for (const [key, count] of Object.entries(LETTER_POOL)) {
const start = letterBank.length;
letterBank.length += count;
letterBank.fill(key, start, letterBank.length);
}
Comment on lines +63 to +68

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rad! This totally works and I learned about Object.entries() syntax from this bit of code so thank you! Another way we could go about this:

for (const letter in LETTER_POOL) {
    for (let i = 0; i < LETTER_POOL[letter]; i++) {
        letterBank.push(letter) 
    }
}

// Build a hand of ten random strings from the letterBank removing selected letter fom letterBank
for (let i = 0; i < 10; i++) {
let temp = Math.floor(Math.random() * letterBank.length);
hand.push(letterBank[temp]);
letterBank.splice(temp, 1);
}
return hand;
};
Comment on lines +70 to 76

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmmm, love the JS syntax for randomly picking 10 numbers (not really but this is probably the best way we can do this)!


export const usesAvailableLetters = (input, lettersInHand) => {
// Implement this method for wave 2
input = input.toUpperCase();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice way to standardize the input! 💯

let handCopy = [...lettersInHand];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delicious destructuring on this line! 👨🏻‍🍳

for (let i = 0; i < input.length; i++) {
if (!handCopy.includes(input[i])) {
return false;
}
let index = handCopy.indexOf(input[i]);
handCopy.splice(index, 1);
}
return true;
};

export const scoreWord = (word) => {
// Implement this method for wave 3
word = word.toUpperCase();
let score = 0;
for (let i = 0; i < word.length; i++) {
score += LETTER_SCORE[word[i]];
}
if (word.length > 6) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost! The instructions for Wave 3 says If the length of the word is 7, 8, 9, or 10, then the word gets an additional 8 points so we should add a second conditional here to get the right range!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see your point but if you tried to pass on any word with more than ten letters you wouldnt have made it past UsesAvailableLetters and your dirty cheater word would have ben declared invalid prior to scoring. So setting the upper limit at 10 here is redundant and I saved at least six whole key strokes! Thank you for all the kind words. Made me smile.

score += 8;
}
return score;
};

export const highestScoreFrom = (words) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great logic for highestScoreFrom! 🚀

// Implement this method for wave 1
const highestWord = {
score: 0,
word: "",
};
for (let i = 0; i < words.length; i++) {
if (scoreWord(words[i]) > highestWord.score) {
highestWord.score = scoreWord(words[i]);
highestWord.word = words[i];
} else if (scoreWord(words[i]) === highestWord.score) {
if (highestWord.word.length === 10) {
continue;
} else if (words[i].length === 10) {
highestWord.word = words[i];
} else if (highestWord.word.length > words[i].length) {
highestWord.word = words[i];
}
}
}
return highestWord;
};
8 changes: 5 additions & 3 deletions test/adagrams.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,9 @@ describe("Adagrams", () => {
});

it("returns a score of 0 if given an empty input", () => {
throw "Complete test";
expectScores({
"": 0,
});
});

it("adds an extra 8 points if word is 7 or more characters long", () => {
Expand All @@ -133,7 +135,7 @@ describe("Adagrams", () => {
});
});

describe.skip("highestScoreFrom", () => {
describe("highestScoreFrom", () => {
it("returns a hash that contains the word and score of best word in an array", () => {
const words = ["X", "XX", "XXX", "XXXX"];
const correct = { word: "XXXX", score: scoreWord("XXXX") };
Expand All @@ -145,7 +147,7 @@ describe("Adagrams", () => {
const words = ["XXX", "XXXX", "X", "XX"];
const correct = { word: "XXXX", score: scoreWord("XXXX") };

throw "Complete test by adding an assertion";
expect(highestScoreFrom(words)).toEqual(correct);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

});

describe("in case of tied score", () => {
Expand Down