-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Otters - Jodi Denney #98
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,123 @@ | ||
// import { LETTER_POOL } from "../test/adagrams.test"; | ||
const LETTER_POOL = { | ||
A: 9, | ||
B: 2, | ||
C: 2, | ||
D: 4, | ||
E: 12, | ||
F: 2, | ||
G: 3, | ||
H: 2, | ||
I: 9, | ||
J: 1, | ||
K: 1, | ||
L: 4, | ||
M: 2, | ||
N: 6, | ||
O: 8, | ||
P: 2, | ||
Q: 1, | ||
R: 6, | ||
S: 4, | ||
T: 6, | ||
U: 4, | ||
V: 2, | ||
W: 2, | ||
X: 1, | ||
Y: 2, | ||
Z: 1, | ||
}; | ||
|
||
const LETTER_SCORE = { | ||
A: 1, | ||
B: 3, | ||
C: 3, | ||
D: 2, | ||
E: 1, | ||
F: 4, | ||
G: 2, | ||
H: 4, | ||
I: 1, | ||
J: 8, | ||
K: 5, | ||
L: 1, | ||
M: 3, | ||
N: 1, | ||
O: 1, | ||
P: 3, | ||
Q: 10, | ||
R: 1, | ||
S: 1, | ||
T: 1, | ||
U: 1, | ||
V: 4, | ||
W: 4, | ||
X: 8, | ||
Y: 4, | ||
Z: 10, | ||
}; | ||
|
||
export const drawLetters = () => { | ||
// Implement this method for wave 1 | ||
const hand = []; | ||
const letterBank = []; | ||
// Build a letterBank array where each letters appearance is accurately weighted | ||
for (const [key, count] of Object.entries(LETTER_POOL)) { | ||
const start = letterBank.length; | ||
letterBank.length += count; | ||
letterBank.fill(key, start, letterBank.length); | ||
} | ||
Comment on lines
+63
to
+68
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Rad! This totally works and I learned about
|
||
// Build a hand of ten random strings from the letterBank removing selected letter fom letterBank | ||
for (let i = 0; i < 10; i++) { | ||
let temp = Math.floor(Math.random() * letterBank.length); | ||
hand.push(letterBank[temp]); | ||
letterBank.splice(temp, 1); | ||
} | ||
return hand; | ||
}; | ||
Comment on lines
+70
to
76
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Mmmm, love the JS syntax for randomly picking 10 numbers (not really but this is probably the best way we can do this)! |
||
|
||
export const usesAvailableLetters = (input, lettersInHand) => { | ||
// Implement this method for wave 2 | ||
input = input.toUpperCase(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice way to standardize the input! 💯 |
||
let handCopy = [...lettersInHand]; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Delicious destructuring on this line! 👨🏻🍳 |
||
for (let i = 0; i < input.length; i++) { | ||
if (!handCopy.includes(input[i])) { | ||
return false; | ||
} | ||
let index = handCopy.indexOf(input[i]); | ||
handCopy.splice(index, 1); | ||
} | ||
return true; | ||
}; | ||
|
||
export const scoreWord = (word) => { | ||
// Implement this method for wave 3 | ||
word = word.toUpperCase(); | ||
let score = 0; | ||
for (let i = 0; i < word.length; i++) { | ||
score += LETTER_SCORE[word[i]]; | ||
} | ||
if (word.length > 6) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Almost! The instructions for Wave 3 says There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see your point but if you tried to pass on any word with more than ten letters you wouldnt have made it past UsesAvailableLetters and your dirty cheater word would have ben declared invalid prior to scoring. So setting the upper limit at 10 here is redundant and I saved at least six whole key strokes! Thank you for all the kind words. Made me smile. |
||
score += 8; | ||
} | ||
return score; | ||
}; | ||
|
||
export const highestScoreFrom = (words) => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Great logic for |
||
// Implement this method for wave 1 | ||
const highestWord = { | ||
score: 0, | ||
word: "", | ||
}; | ||
for (let i = 0; i < words.length; i++) { | ||
if (scoreWord(words[i]) > highestWord.score) { | ||
highestWord.score = scoreWord(words[i]); | ||
highestWord.word = words[i]; | ||
} else if (scoreWord(words[i]) === highestWord.score) { | ||
if (highestWord.word.length === 10) { | ||
continue; | ||
} else if (words[i].length === 10) { | ||
highestWord.word = words[i]; | ||
} else if (highestWord.word.length > words[i].length) { | ||
highestWord.word = words[i]; | ||
} | ||
} | ||
} | ||
return highestWord; | ||
}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -120,7 +120,9 @@ describe("Adagrams", () => { | |
}); | ||
|
||
it("returns a score of 0 if given an empty input", () => { | ||
throw "Complete test"; | ||
expectScores({ | ||
"": 0, | ||
}); | ||
}); | ||
|
||
it("adds an extra 8 points if word is 7 or more characters long", () => { | ||
|
@@ -133,7 +135,7 @@ describe("Adagrams", () => { | |
}); | ||
}); | ||
|
||
describe.skip("highestScoreFrom", () => { | ||
describe("highestScoreFrom", () => { | ||
it("returns a hash that contains the word and score of best word in an array", () => { | ||
const words = ["X", "XX", "XXX", "XXXX"]; | ||
const correct = { word: "XXXX", score: scoreWord("XXXX") }; | ||
|
@@ -145,7 +147,7 @@ describe("Adagrams", () => { | |
const words = ["XXX", "XXXX", "X", "XX"]; | ||
const correct = { word: "XXXX", score: scoreWord("XXXX") }; | ||
|
||
throw "Complete test by adding an assertion"; | ||
expect(highestScoreFrom(words)).toEqual(correct); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍🏻 |
||
}); | ||
|
||
describe("in case of tied score", () => { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great use of the JS constant variable here at the top of the file! ✨