Otters - Amel Ntamark #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaidamasaki
reviewed
Jun 10, 2022
Comment on lines
+28
to
+31
| favorite color: purple<br><br> | ||
| favorite show: the good place<br><br> | ||
| favorite song: <iframe style="border-radius:12px" src="https://open.spotify.com/embed/track/29d0nY7TzCoi22XBqDQkiP?utm_source=generator" width="100%" height="80" frameBorder="0" allowfullscreen="" allow="autoplay; clipboard-write; encrypted-media; fullscreen; picture-in-picture"></iframe> |
There was a problem hiding this comment.
Style: Using a ul or simple paragraphs instead of having a bunch of brs would be cleaner.
From MDN:
Creating separate paragraphs of text using
<br>is not only bad practice, it is problematic for people who navigate with the aid of screen reading technology. Screen readers may announce the presence of the element, but not any content contained within<br>s. This can be a confusing and frustrating experience for the person using the screen reader.
To read more: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/br
There was a problem hiding this comment.
Thank you for sharing this info Kaida! ✨
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Amel Ntamark | About</title> | ||
| <meta name="description" content="about amel ntamark and how to contact" /> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Personal Portfolio Site
Congratulations! You're submitting your assignment!
Comprehension Questions