Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sea Turtles Carranza, Katina #93

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Sea Turtles Carranza, Katina #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2223a6c
Submission of Personal Portfolio Project
kmcarranza May 24, 2022
c34400a
Ran HTML Validator
kmcarranza May 24, 2022
42b3ec8
Completed incomplete Project Requirements ***added links and graphics…
kmcarranza Jul 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"liveServer.settings.port": 5502
}
Binary file added images/Baby-Photos.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/anagram.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/completed-task.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/solar-system.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 7 additions & 2 deletions pages/about.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,14 @@
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
<title>About</title>
</head>
<body>

<h1>All About Katina</h1>
<p>This is information about likes and dislikes for Katina</p>
<footer> This is Katina's footer
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the links to your other pages should go inside of a nav tag something like

<header>
<nav>
<ul>
<li><a href="index.html">Home</a></li>
<li><a href="portfolio.html">Portfolio</a></li>
</ul>
</nav>
</header>

<a href="index.html">Home</a>
<a href="portfolio.html">Portfolio</a>
</footer>
</body>
</html>
33 changes: 31 additions & 2 deletions pages/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,38 @@
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
<link href="../styles/style.css" rel="stylesheet">
<title>Katina Carranza Personal Portfolio</title>
</head>
<body>

<h1>
My Personal Portfolio
</h1>
<section class="container">
<div>
<h2>
Home
</h2>
<h2>
<a href="about.html">About</a>
</h2>
<h2>
<a href = "portfolio.html">Portfolio</a>
</h2>
</div>
Comment on lines +11 to +25
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section should be inside of a header tag and nav tag.

Comment on lines +11 to +25
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section should be inside of a header tag and nav tag.

<img
alt= "Baby Photos" src = "/images/Baby-Photos.jpg" >
<div class = "purple" >
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of div tags you want to use section tags here. Here is a link to an article describing the difference between the two. https://www.geeksforgeeks.org/what-is-the-difference-between-section-and-div-tags-in-html/

Katina's interests
</div>
<div class = "purple" >
Katina's Troubleshooting
</div>
</section>
<footer>
<div class = "purple" >
<nav>This is my Nav bar.</nav>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be at the top of your page in a header tag

</div>This is Katina's footer
</footer>
</body>
</html>
17 changes: 15 additions & 2 deletions pages/portfolio.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,22 @@
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
<title>Portfolio</title>
</head>
<body>

<h1>Katina's Portofolio</h1>
<img alt= "Adagrams" src = "/images/anagram.png" >
<a href="https://github.com/lili4x4/adagrams-py">Adagrams</a>
<img alt= "Task List API" src = "/images/completed-task.png" >
<a href="https://github.com/kmcarranza/task-list-api">Task List API</a>
<img alt= "Solar Systems" src = "/images/solar-system.png" >
<a href="https://github.com/perugia33/solar-system-api">Solar Systems API</a>
<footer> This is Katina's footer
<a href="index.html">Home</a>
<a href="about.html">About</a>
Comment on lines +18 to +19
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be in a header and nav tag at the top of your page

</footer>
<a href="https://www.flaticon.com/free-icons/anagram" title="anagram icons">Anagram icons created by Freepik - Flaticon</a>
<a href="https://www.flaticon.com/free-icons/solar-system" title="solar system icons">Solar system icons created by Freepik - Flaticon</a>
<a href="https://www.flaticon.com/free-icons/survey" title="survey icons">Survey icons created by Pixelmeetup - Flaticon</a>
</body>
</html>
34 changes: 34 additions & 0 deletions styles/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
nav{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would take a look at this example from W3 schools. It shows a basic html template with css. It shows you a header, body, and footer with styling. https://www.w3schools.com/w3css/tryit.asp?filename=tryw3css_containers_semantic_article

color: purple;
}
.container{
display: flex;
flex-direction: Row;
flex-wrap:wrap;
justify-content: space-around;
align-items: center;
height: 750px;
background-color: lavender;
}
div{
width: 800px;
height: 300px;
display: grid;
}

img{
width: 200px;
height: 150px;
}
#purple{
display: block;
background-color: aqua;
align-items:flex-start;
height: 75px;
width: 250px;
}
h1{
display: grid;
align-items: center;
color: purple;
}