Sea Turtles/ Theresa Davis #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgoslee
reviewed
Jun 18, 2022
| @@ -0,0 +1,251 @@ | |||
| :root { | |||
There was a problem hiding this comment.
your css page looks good. Remove the commented properties that you aren't using.
|
|
||
|
|
||
| <header class = "container"> | ||
| <div id=" header"> |
There was a problem hiding this comment.
you are using a lot of div tags in this file. I wanted to share a resource to help you decipher when to use div tags and when not to:
| @@ -0,0 +1,244 @@ | |||
| // const axios = require('axios'); | |||
|
|
|||
| const state ={ | |||
| const updateSky = (e) =>{ | ||
| e.preventDefault() | ||
| let selectSkyValue = document.getElementById("skyOptions").value; | ||
| console.log(selectSkyValue) |
There was a problem hiding this comment.
remove your console log here and on line 22, 29, 35, 42
Comment on lines
+65
to
+116
| const increaseTemp = () =>{ | ||
|
|
||
| const temperature = document.getElementById("temperature"); | ||
| state.temperature += 1; | ||
| temperature.textContent = `${state.temperature}°`; | ||
| updateTempColor(); | ||
|
|
||
| console.log(temperature) | ||
| } | ||
|
|
||
|
|
||
| const decreaseTemp = () =>{ | ||
|
|
||
| const temperature = document.getElementById("temperature"); | ||
| // const tempColor = document.getElementById("tempColor"); | ||
| state.temperature -= 1; | ||
| temperature.textContent = `${state.temperature}°`; | ||
| updateTempColor(); | ||
| console.log(temperature) | ||
| } | ||
|
|
||
|
|
||
| const updateTempColor = () =>{ | ||
| const tempColor = document.getElementById("tempColor"); | ||
| const newTemp = state.temperature; | ||
| if (newTemp >= 70 && newTemp <= 79){ | ||
| tempColor.className = `warm`; | ||
| console.log(`${tempColor.className}`) | ||
| } | ||
|
|
||
| else if (newTemp >= 80){ | ||
| tempColor.className = `very-hot`; | ||
| console.log(state.temperature) | ||
| console.log(` this is the class name ${tempColor.className}`) | ||
| } | ||
|
|
||
| else if (newTemp >= 60 && newTemp <= 69){ | ||
| tempColor.className = `cool`; | ||
| console.log(`${tempColor.className}`) | ||
| } | ||
|
|
||
| else if (newTemp >= 50 && newTemp <= 59){ | ||
| tempColor.className = `chilly`; | ||
| console.log(`${tempColor.className}`) | ||
| } | ||
|
|
||
| else if (newTemp <= 49){ | ||
| tempColor.className = `cold`; | ||
| console.log(state.temperature) | ||
| console.log(` this is the class name ${tempColor.className}`) | ||
| } | ||
| } |
There was a problem hiding this comment.
You can remove all of the console logs. Instead of else if I want you to also look at using a switch statement take a look https://www.w3schools.com/js/js_switch.asp
Comment on lines
+187
to
+196
| // resetCity = "" | ||
| // state.cityName = "Seattle WA" | ||
| // location.textContent = `${state.location}`; | ||
| // console.log(`${state.location}`) | ||
|
|
||
| } | ||
| // let inputValue = document.getElementById("location").value; | ||
| // let cityName = document.getElementById("cityName").innerHTML | ||
| // document.getElementById("cityName").innerHTML = inputValue; | ||
| // state.cityName = inputValue |
|
|
||
|
|
||
|
|
||
| // function call - getLatAndLong(); |
| // state.cityName = inputValue | ||
|
|
||
| // REGISTER EVENT HANDLERS | ||
| const registerEventHandlers = ( ) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.