143 ui improvements #94

sherzinger · 2020-01-23T13:47:52Z

public/javascripts/main.js

…ovements # Conflicts: # public/javascripts/main.js

sherzinger · 2020-02-04T09:19:25Z

Okay, so this PR got a lot bigger than initially planned.

I had to refactor the typeahead method calls got get some sanity in the the long list of parameters
I had to edit the asset pipeline because of unmaintained sbt-web packages
I had to remove the ".min" from all previously "closured" .js files because they are no longer minified, but gziped instead. I tried to use sbt-uglify to introduce minification again but that's another library that's not well maintained. Unfortunately sbt-web seems to be very poorly maintained in general.
I had to find the occurrences of field typeaheads and edit the minLength to 2 (the default is 0, e.g. for filter typeahead)

Please have a look if the front-end still works as expected. I couldn't find any issues here.

sherzinger added 3 commits January 23, 2020 10:22

dblclick -> click + event bubbling fix

b503850

improved field name style when sorted in table view

f2ab1ff

made autocomplete scrollable and only show after 2 letters

40554e6

peterbanda reviewed Jan 23, 2020

View reviewed changes

public/javascripts/main.js Outdated Show resolved Hide resolved

sherzinger added 11 commits January 28, 2020 08:23

typeahed -> typeahead

8117c69

refactored typeahead methods

c9ed917

setting spark host

225b01c

Merge remote-tracking branch 'remotes/origin/master' into 143-ui-impr…

3569cea

…ovements # Conflicts: # public/javascripts/main.js

removed closure compiler as it's no longer maintained

4526876

merged

929f9ad

fixed a few issues introduced by the refactor

584cc13

disabling css compress (gzip is still active)

30e1fe9

fixed some more issues

5d11c1b

populateFieldTypeaheads -> populateFieldTypeahead

96921b3

setting fields typeahead to minLength 2

325d851

sherzinger assigned peterbanda Feb 4, 2020

sherzinger requested a review from peterbanda February 4, 2020 09:20

Provide feedback