Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented IR rawSend in IRsend class #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

idankri
Copy link

@idankri idankri commented Jan 3, 2021

Hi!
I noticed there is no implemented support for sending raw IR data.
The relevant function is written in IRLib_HashRaw.h, which had no include statement in IRLibCPE.h, and in addition the only linkage was broken:
The next line is a line is in IRLib_HashRaw.h:
#define IR_SEND_RAW case 0: IRsendRaw::send((uint16_t*)data,data2,khz); break;

The IR_SEND_RAW macro is used in IRLibCombo.h in IRsend class, in the send method, in order to send raw transmission. That will always result as an illegal cast between uint32_t to uint16_t* .
As a result it's impossible to use this method from the built-in IRsend object in the main object of CircuitPlayground.
IMO the send raw functionality should be separated from the other IR send's functionality as it receives different parameters.
Hope that helps :)
Idan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant