Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding HUSB238 #440

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Adding HUSB238 #440

merged 2 commits into from
Oct 24, 2023

Conversation

BlitzCityDIY
Copy link
Contributor

Adding the HUSB238 library. If someone with access to ReadTheDocs is able to accept the adabot invite and add to the CircuitPython project I'd appreciate it 🙂

@BlitzCityDIY BlitzCityDIY requested a review from a team October 24, 2023 15:14
@tannewt
Copy link
Member

tannewt commented Oct 24, 2023

Accepted and added as a subproject.

tannewt
tannewt requested changes Oct 24, 2023
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a third file added for the folder of the library itself.

@BlitzCityDIY
Copy link
Contributor Author

@tannewt thanks! sorry about that, forgot to submodule 🤦‍♀️

tannewt
tannewt approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@BlitzCityDIY BlitzCityDIY merged commit 1ea5cb2 into main Oct 24, 2023
2 checks passed
@BlitzCityDIY BlitzCityDIY deleted the husb238 branch October 24, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BlitzCityDIY @tannewt