Fixed truecolor bmp not using provided bitmap constructor #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Thank you @shawn-mcgee
This makes sense and looks good to me.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 8, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_TCA8418 to 1.0.14 from 1.0.13: > Merge pull request adafruit/Adafruit_CircuitPython_TCA8418#15 from devau-remi/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 1.23.5 from 1.23.3: > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#90 from FoamyGuy/colorconvert_in_docstring > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#89 from shawn-mcgee/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that this function always seemed to return a vanilla
display.ioBitmap despite being provided a custom constructor. Looked into the source and discovered that the custom constructor was being ignored. 👍Presto chango, the typo is now fixed.